> On April 1, 2015, 4:25 p.m., Martin Klapetek wrote: > > This breaks ABI...? > > > > Also, is it not possible to just register the Tp type directly with QML? > > David Edmundson wrote: > Yes it does break ABI, but is that a problem? > > I don't think using the TpQt enum is possible, not without changing TpQt. > > The best we could possibly do is export it in the property as > Tp::ConnectionStatus, then rely on the fact that QML just treats it all as an > int and using some other enum on the QML side. > > or I could just keep it as a boolean accessor like I did in the 15.04 > branch.
> Yes it does break ABI, but is that a problem? Obviously. > or I could just keep it as a boolean accessor like I did in the 15.04 branch. Honestly I don't see any need for the particular state, it's either connecting or not, the rest is displayed via the presence. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123209/#review78339 ----------------------------------------------------------- On April 1, 2015, 3:29 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123209/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 3:29 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Not sure I like it, I have to shadow an enum which gets messy. Dunno. > > > Diffs > ----- > > KTp/global-presence.h 61a35bb > KTp/global-presence.cpp d47a695 > > Diff: https://git.reviewboard.kde.org/r/123209/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
