> On April 21, 2015, 12:33 p.m., Aleix Pol Gonzalez wrote: > > chat/org.kde.ktp-chat/contents/ui/FullChatList.qml, line 31 > > <https://git.reviewboard.kde.org/r/123445/diff/1/?file=362235#file362235line31> > > > > I don't really understand why you changed all the types either. > > > > QtQuick.Layouts operates on qreal.
We use ints everywhere in plasma as reals cause sub-pixel alignment, which is unwanted. I see no reason to have that? > On April 21, 2015, 12:33 p.m., Aleix Pol Gonzalez wrote: > > chat/org.kde.ktp-chat/contents/ui/FullChatList.qml, line 33 > > <https://git.reviewboard.kde.org/r/123445/diff/1/?file=362235#file362235line33> > > > > Please don't change that. It's not correct. > > > > The plasmoid supports being on a vertical and horizontal layout, > > therefore thickness and length nomenclature. > > > > When the width exceedes thickness, the dimensions are swapped. This nomenclature however is not used anywhere else and it's confusing when working with it; it still is width/height even when rotated, isn't it? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123445/#review79277 ----------------------------------------------------------- On April 21, 2015, 12:10 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123445/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 12:10 p.m.) > > > Review request for Telepathy. > > > Bugs: 298306 > http://bugs.kde.org/show_bug.cgi?id=298306 > > > Repository: ktp-desktop-applets > > > Description > ------- > > Just like the Pager applet, collapse when there's nothing to show. > Consistency++ > > Also fix the property type & name - Length -> Width, Thickness -> Height, > real -> int > > > Diffs > ----- > > chat/org.kde.ktp-chat/contents/ui/FullChatList.qml db6d420 > > Diff: https://git.reviewboard.kde.org/r/123445/diff/ > > > Testing > ------- > > Added to panel, takes no space, opened a chat, opened another chat, closed > chat, opened another chat, closed chat, closed chat, takes no space in panel. > And it resized always correctly when opening/closing. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
