----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123893/#review80772 -----------------------------------------------------------
I think I understand where you're coming from, but I'm unsure it makes sense. Won't it be weird if you change your emoticons theme and then it only gets applied for some accounts? - Aleix Pol Gonzalez On May 24, 2015, 1:50 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123893/ > ----------------------------------------------------------- > > (Updated May 24, 2015, 1:50 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-text-ui > > > Description > ------- > > The name of emoticon theme for account is stored in ktelepathyrc and then > used by ktp-text-ui. > If there is no specified emoticon theme, the default emoticon theme is used. > > This needs UI somewhere in settings to configure the emoticons for each > account. I'm not sure where to put it (in kaccounts-kcm?), so suggestions > welcome. > > > Diffs > ----- > > app/emoticon-text-edit-action.h a5ae531 > app/emoticon-text-edit-action.cpp 2ee628e > app/emoticon-text-edit-selector.h fb1584f > app/emoticon-text-edit-selector.cpp 22742fb > filters/emoticons/CMakeLists.txt 447b223 > filters/emoticons/emoticon-filter.h 0f5a1ec > filters/emoticons/emoticon-filter.cpp 565ae84 > lib/CMakeLists.txt d6af848 > lib/emoticons-manager.h PRE-CREATION > lib/emoticons-manager.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123893/diff/ > > > Testing > ------- > > Works fine > > > Thanks, > > David Rosca > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
