> On May 26, 2015, 6:34 p.m., Martin Klapetek wrote: > > > but we should not use QCommandLinkButton as it is activated on press (and > > > there is no way to easily change it). > > > > QCommandLinkButton derives from QPushButton, it has exactly the same > > signals including clicked(); there's really no reason to change that. I'll > > be changing it back to QCommandLinkButton. > > David Rosca wrote: > That's correct, sorry. When I tested it, for some reason I incorrectly > thought the clicked signal is emitted on button press. > But there actually is now a reason to use QPushButton instead of > QCommandLinkButton: QCommandLinkButton don't have vertically aligned icon and > text in Breeze style ( > http://wstaw.org/m/2015/05/26/qcommandlinkbutton-breeze.png this is with this > commit reverted). > It should be fixed in Breeze, but still... > > Martin Klapetek wrote: > Yes, that's a bug in different product and should be fixed there, we > shouldn't really be working around it, especially if we have an (relatively > easy) way of fixing the cause of the bug. Plus, QPushButton cannot > horizontally align things, which imo is a bigger (visual) issue ;)
For record keeping: https://bugs.kde.org/show_bug.cgi?id=348257 - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123546/#review80854 ----------------------------------------------------------- On May 11, 2015, 12:10 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123546/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 12:10 a.m.) > > > Review request for Telepathy and Martin Klapetek. > > > Repository: kaccounts-integration > > > Description > ------- > > Connect to QPushButton::clicked signal instead of QPushButton::pressed. > > This makes it consistent with other buttons, eg. the button action is > activated only when releasing the mouse inside the button rect, not > immediately on mouse press. > It is also needed to change QCommandLinkButton to QPushButton, where it > changes the text alignment from left-aligned to center-aligned. I don't know > how to replicate the look with > QPushButton, but we should not use QCommandLinkButton as it is activated on > press (and there is no way to easily change it). > > > Diffs > ----- > > src/accountwidget.cpp a56cf04 > src/create.cpp 5e4d46e > > Diff: https://git.reviewboard.kde.org/r/123546/diff/ > > > Testing > ------- > > Buttons are now activated on mouse release. > > > Thanks, > > David Rosca > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
