----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123915/#review80888 -----------------------------------------------------------
Good start; while we're doing our own control, can we get the label vertically center aligned with the icon? --> https://dl.dropboxusercontent.com/u/6761102/kaccounts_buttons.png src/create.cpp (lines 44 - 46) <https://git.reviewboard.kde.org/r/123915/#comment55415> I think we could just drop the bold font? src/create.cpp (line 59) <https://git.reviewboard.kde.org/r/123915/#comment55416> This will break on hidpi - Martin Klapetek On May 27, 2015, 12:08 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123915/ > ----------------------------------------------------------- > > (Updated May 27, 2015, 12:08 p.m.) > > > Review request for Telepathy. > > > Repository: kaccounts-integration > > > Description > ------- > > The custom button uses same paint code as QCommonStyle, but it sets width of > the rect to width of icon and text when drawing CE_PushButtonLabel which > forces the contents to be left aligned. > > > Diffs > ----- > > src/create.cpp 49ce1bd > > Diff: https://git.reviewboard.kde.org/r/123915/diff/ > > > Testing > ------- > > Button contents are now left aligned, same as with QCommandLinkButton. Tested > with Breeze, Oxygen, Fusion, win9x and GTK+ Oxygen styles. > > > Thanks, > > David Rosca > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
