----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124310/#review82287 -----------------------------------------------------------
chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml (line 91) <https://git.reviewboard.kde.org/r/124310/#comment56664> I would rather not. We used to have this scrollbar. It doesn't add anything to the plate, it takes space and it did't work all that well. chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml (line 142) <https://git.reviewboard.kde.org/r/124310/#comment56665> don't remove followConversation, we need it to go false only when the user moves the flickable. Sending a message or receiving an image can do that as well. - Aleix Pol Gonzalez On July 9, 2015, 8:03 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124310/ > ----------------------------------------------------------- > > (Updated July 9, 2015, 8:03 p.m.) > > > Review request for Plasma and Telepathy. > > > Repository: ktp-desktop-applets > > > Description > ------- > > This improves the chat widget by: > - Not hardcoding the hader size > - Using a heading for the name so it stands out a bit more (since it's often > not obvious at a glance who you're writing to) > - Giving it a proper scroll bar > - Making the auto scrolling a bit more robust > - Cleaing up the code a bit > > > Diffs > ----- > > chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 4e802c7 > > Diff: https://git.reviewboard.kde.org/r/124310/diff/ > > > Testing > ------- > > Been using it for a while, works nicely and looks better > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
