----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127005/#review92169 -----------------------------------------------------------
Thanks for working on this Do you know what's the status of webengine packaging in distros? Last time I remember they were much unhappy about it. If they cannot package that, we won't be able to use this. That said, do the filter plugins work too? lib/adium-theme-view.h <https://git.reviewboard.kde.org/r/127005/#comment62877> This worked based on a config file option. I imagine we can replace this with qputenv("QTWEBENGINE_REMOTE_DEBUGGING"...) instead? Ie. keep the config option working. lib/adium-theme-view.cpp (line 97) <https://git.reviewboard.kde.org/r/127005/#comment62874> Use the new connect syntax lib/adium-theme-view.cpp <https://git.reviewboard.kde.org/r/127005/#comment62880> This seems to be lost? lib/adium-theme-view.cpp <https://git.reviewboard.kde.org/r/127005/#comment62876> Why this whole thing is being removed? lib/chat-widget.cpp (lines 246 - 249) <https://git.reviewboard.kde.org/r/127005/#comment62878> While changing these, use the new connect syntax logviewer/message-view.cpp (lines 53 - 54) <https://git.reviewboard.kde.org/r/127005/#comment62879> Use new connect syntax - Martin Klapetek On Feb. 7, 2016, 9:21 p.m., Niels Ole Salscheider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127005/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2016, 9:21 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-text-ui > > > Description > ------- > > This ports the message viewer from QWebKit to QWebEngine. > > > Diffs > ----- > > CMakeLists.txt 91cd304 > adiumxtra-protocol-handler/CMakeLists.txt f78a62f > app/CMakeLists.txt 9a90cec > config/appearance/CMakeLists.txt dfb5d04 > config/appearance/appearance-config-tab.cpp f2f298b > lib/CMakeLists.txt 5294521 > lib/adium-theme-view.h 5a0c2e6 > lib/adium-theme-view.cpp 26e6d50 > lib/chat-search-bar.h c8c5118 > lib/chat-search-bar.cpp 484975a > lib/chat-widget.h 588407c > lib/chat-widget.cpp 7975057 > logviewer/CMakeLists.txt c36157c > logviewer/log-viewer.cpp 1ae0f7b > logviewer/message-view.h ec592c7 > logviewer/message-view.cpp eafc53e > > Diff: https://git.reviewboard.kde.org/r/127005/diff/ > > > Testing > ------- > > - Builds > - Chats with the text UI work > - Links work > - The log viewer works > > > Thanks, > > Niels Ole Salscheider > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
