----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126834/ -----------------------------------------------------------
(Updated Dec. 15, 2016, 6:25 p.m.) Review request for Telepathy and David Edmundson. Changes ------- Refactor. 1) Remove m_modelFinishedLoading. 2) presenceModelChanged() -> propagationChange(). 3) New modifyModel(KTp::Presence), merges addPresence() and removePresence(). 4) propagateModelChange() -> propagateChange(), no longer takes an overload boolean. m_presences is now checked if it contains the propagating presence instead. 5) Undo change loadDefaultPresences() and loadCustomPresences() into public Q_SLOTS. 6) Spread DBus slot connection over multiple lines. 6) Debug changes. Repository: ktp-common-internals Description ------- New features: -Simplified API, sends and collects changes over DBus. Diffs (updated) ----- KTp/Models/presence-model.h 8f206b880f48640626322269a14956f105482f69 KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519 Diff: https://git.reviewboard.kde.org/r/126834/diff/ Testing ------- Compile, run. Thanks, James Smith
