Patrick Spendrin schrieb:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Ralf Habacker schrieb:
Hi,
since r1025903 krusader sources are fetched from kde svn and it not
compilable because of a missing patch, which was applied before the
mentioned release.
the patch wasn't applied for svnHEAD in the old krusader svn head but
instead only for the 2.0.0-beta2 package. You can still get this package
using emerge --target=2.0.0-beta2 krusader . If this shouldn't work,
then please tell me again.
[ 52%] Building CXX object krusader/Queue/CMakeFiles/Queue.dir/queue_mgr.obj
queue_mgr.cpp
D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\Queue\queue_mgr.cpp(47)
: error C2057: Konstanter Ausdruck erwartet
D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\Queue\queue_mgr.cpp(47)
: error C2466: Zuordnung eines Arrays der konstanten Größe 0 nicht möglich.
D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\Queue\queue_mgr.cpp(47)
: error C2133: 'queueArray': Unbekannte Größe
The related source line is listed below:
Queue *queueArray [ queuesSize ];
There are more issues:
D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\main.cpp(78) :
error C2057: Konstanter Ausdruck erwartet
D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\main.cpp(78) :
error C2466: Zuordnung eines Arrays der konstanten Größe 0 nicht möglich.
D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\main.cpp(78) :
error C2133: 'myArgv': Unbekannte Größe
char myArgv[argc+2];
D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\main.cpp(88) :
error C2057: Konstanter Ausdruck erwartet
D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\main.cpp(88) :
error C2466: Zuordnung eines Arrays der konstanten Größe 0 nicht möglich.
D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\main.cpp(88) :
error C2133: 'addedParams': Unbekannte Größe
char addedParams[strlen(icon_text)+strlen(icon_name)+2];
Please make sure that the directory emerge\portage\testing\krusader is deleted
this directory was deleted before
as this is the old location and might interfere with the new build (Maybe this
is the problem you found)!
It looks no, see above
Appended is a related patch, should I fix this in kde svn ?
Beside the compile problems, krusader crashes in krvfsmodel.cpp:285
because t is 0 in line 283
283: struct tm* t = localtime((time_t *) & time);
.
285: QDateTime tmp(QDate(t->tm_year + 1900, t->tm_mon + 1,
t->tm_mday), QTime(t->tm_hour, t->tm_min));
This happens on several places in the sources, a possible solution may
be to use the time_t conversation method of QDateTime
Regards
Ralf
Index:
D:/daten/kde/svn/trunk/extragear/utils/krusader/krusader/Dialogs/checksumdlg.cpp
===================================================================
---
D:/daten/kde/svn/trunk/extragear/utils/krusader/krusader/Dialogs/checksumdlg.cpp
(Revision 1028588)
+++
D:/daten/kde/svn/trunk/extragear/utils/krusader/krusader/Dialogs/checksumdlg.cpp
(Arbeitskopie)
@@ -49,7 +49,7 @@
class CS_Tool; // forward
typedef void PREPARE_PROC_FUNC(KProcess& proc, CS_Tool *self, const
QStringList& files,
- const QString checksumFile, bool recursive,
const QString& type = QString());
+ const QString checksumFile, bool recursive,
const QString& type);
typedef QStringList GET_FAILED_FUNC(const QStringList& stdOut, const
QStringList& stdErr);
class CS_Tool
Index:
D:/daten/kde/svn/trunk/extragear/utils/krusader/krusader/Queue/queue_mgr.cpp
===================================================================
---
D:/daten/kde/svn/trunk/extragear/utils/krusader/krusader/Queue/queue_mgr.cpp
(Revision 1028588)
+++
D:/daten/kde/svn/trunk/extragear/utils/krusader/krusader/Queue/queue_mgr.cpp
(Arbeitskopie)
@@ -44,7 +44,7 @@
if (queuesSize == 0)
queues << defaultName;
- Queue *queueArray [ queuesSize ];
+ Queue **queueArray = new Queue *[ queues.count() ];
int counter = 0;
foreach(const QString &queueName, queues)
@@ -54,6 +54,8 @@
setCurrentQueue(queueArray[ current ]);
else
setCurrentQueue(queueArray[ 0 ]);
+
+ delete []queueArray;
}
QueueManager::~QueueManager()
Index: D:/daten/kde/svn/trunk/extragear/utils/krusader/krusader/main.cpp
===================================================================
--- D:/daten/kde/svn/trunk/extragear/utils/krusader/krusader/main.cpp
(Revision 1028588)
+++ D:/daten/kde/svn/trunk/extragear/utils/krusader/krusader/main.cpp
(Arbeitskopie)
@@ -75,7 +75,7 @@
bool hasIcon = false;
int i = 0;
- char * myArgv[argc+2];
+ char **myArgv = new char *[argc+2];
// if no --miniicon is given, --icon is used. So we don't need to check for
--miniicon separately
for (i = 0; i < argc; ++i) {
@@ -85,7 +85,7 @@
static const char* const icon_text = "--icon";
const char* icon_name = Krusader::privIcon();
- char addedParams[strlen(icon_text)+strlen(icon_name)+2];
+ char *addedParams = new char[strlen(icon_text)+strlen(icon_name)+2];
if (! hasIcon) {
for (i = 0; i < argc; ++i)
@@ -222,6 +222,8 @@
if (reply.isValid() && (bool)reply) {
fprintf(stderr, "%s", i18n("Application already
running!\n").toLocal8Bit().data());
KStartupInfo::appStarted();
+ delete [] addedParams;
+ delete [] myArgv;
return 1;
}
@@ -267,4 +269,6 @@
// let's go.
return app.exec();
+ delete [] addedParams;
+ delete [] myArgv;
}
Index: D:/daten/kde/svn/trunk/extragear/utils/krusader/krArc/krarc.cpp
===================================================================
--- D:/daten/kde/svn/trunk/extragear/utils/krusader/krArc/krarc.cpp
(Revision 1028588)
+++ D:/daten/kde/svn/trunk/extragear/utils/krusader/krArc/krarc.cpp
(Arbeitskopie)
@@ -62,8 +62,12 @@
f.close(); \
} while(0);
#else
+#ifdef _MSC_VER
+#define KRDEBUG(X)
+#else
#define KRDEBUG(X...)
#endif
+#endif
using namespace KIO;
extern "C"
_______________________________________________
Kde-windows mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-windows
