> On Sept. 11, 2012, 6:55 a.m., Wolfgang Rohdewald wrote: > > portage/kde/kdegames/kajongg/kajongg-20120911.py, line 10 > > <http://git.reviewboard.kde.org/r/106423/diff/1/?file=84964#file84964line10> > > > > kajongg will not run on windows unless you get PyKDE4 running first. > > And it has very different dependencies, libkdegames not being one of them.
Interesting why I left the "libkdegame" in. 1) Should usually be "libkdegames" like all the other files of this change. 2) I have even checked the https://projects.kde.org/projects/kde/kdegames/kajongg/repository/revisions/master/entry/CMakeLists.txt file, and I intended to refactor the dependency. 3) There is pykde in testing, but I do not know if that is functioning. If someone cannot tell off-hand, then I will see when testing these packages. 4) KDE Windows switched to python 3 iirc, and it might be that pykde still requires an older version. I am unsure about that as well. 5) There is also the problem, I raised on kde-games-devel, about the KPatience - kpat inconsistency which hopefully needs to be fixed. I went for the current "kde:kpat" way, but I would personally appreciate "kde:kpatience" (i.e. not to retain the svn folder name unless this is needed for any backward compatibility). - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106423/#review18836 ----------------------------------------------------------- On Sept. 11, 2012, 6:47 a.m., Laszlo Papp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106423/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 6:47 a.m.) > > > Review request for kdewin and Patrick Spendrin. > > > Description > ------- > > This is just for checking the direction I have picked up. The patch mimics > the kdeedu infrastructure in emerge/portage. > > > Diffs > ----- > > portage/kde/kdegames/bomber/bomber-20120911.py PRE-CREATION > portage/kde/kdegames/bovo/bovo-20120911.py PRE-CREATION > portage/kde/kdegames/granatier/granatier-20120911.py PRE-CREATION > portage/kde/kdegames/kajongg/kajongg-20120911.py PRE-CREATION > portage/kde/kdegames/kapman/kapman-20120911.py PRE-CREATION > portage/kde/kdegames/katomic/katomic-20120911.py PRE-CREATION > portage/kde/kdegames/kblackbox/kblackbox-20120911.py PRE-CREATION > portage/kde/kdegames/kblocks/kblocks-20120911.py PRE-CREATION > portage/kde/kdegames/kbounce/kbounce-20120911.py PRE-CREATION > portage/kde/kdegames/kbreakout/kbreakout-20120911.py PRE-CREATION > portage/kde/kdegames/kdegames-20080202.py 9075ffb > portage/kde/kdegames/kdegames-package.xml 19c06f8 > portage/kde/kdegames/kdiamond/kdiamond-20120911.py PRE-CREATION > portage/kde/kdegames/kfourinline/kfourinline-20120911.py PRE-CREATION > portage/kde/kdegames/kgoldrunner/kgoldrunner-20120911.py PRE-CREATION > portage/kde/kdegames/kigo/kigo-20120911.py PRE-CREATION > portage/kde/kdegames/killbots/killbots-20120911.py PRE-CREATION > portage/kde/kdegames/kiriki/kiriki-20120911.py PRE-CREATION > portage/kde/kdegames/kjumpingcube/kjumpingcube-20120911.py PRE-CREATION > portage/kde/kdegames/klickety/klickety-20120911.py PRE-CREATION > portage/kde/kdegames/klines/klines-20120911.py PRE-CREATION > portage/kde/kdegames/kmahjongg/kmahjongg-20120911.py PRE-CREATION > portage/kde/kdegames/kmines/kmines-20120911.py PRE-CREATION > portage/kde/kdegames/knavalbattle/knavalbattle-20120911.py PRE-CREATION > portage/kde/kdegames/knetwalk/knetwalk-20120911.py PRE-CREATION > portage/kde/kdegames/kolf/kolf-20120911.py PRE-CREATION > portage/kde/kdegames/kollision/kollision-20120911.py PRE-CREATION > portage/kde/kdegames/konquest/konquest-20120911.py PRE-CREATION > portage/kde/kdegames/kpatience/kpatience-20120911.py PRE-CREATION > portage/kde/kdegames/kreversi/kreversi-20120911.py PRE-CREATION > portage/kde/kdegames/kshisen/kshisen-20120911.py PRE-CREATION > portage/kde/kdegames/ksirk/ksirk-20120911.py PRE-CREATION > portage/kde/kdegames/ksnakeduel/ksnakeduel-20120911.py PRE-CREATION > portage/kde/kdegames/kspaceduel/kspaceduel-20120911.py PRE-CREATION > portage/kde/kdegames/ksquares/ksquares-20120911.py PRE-CREATION > portage/kde/kdegames/ksudoku/ksudoku-20120911.py PRE-CREATION > portage/kde/kdegames/ktuberling/ktuberling-20120911.py PRE-CREATION > portage/kde/kdegames/kubrick/kubrick-20120911.py PRE-CREATION > portage/kde/kdegames/libkdegames/libkdegames-20120911.py PRE-CREATION > portage/kde/kdegames/libmahjongg/libmahjongg-20120911.py PRE-CREATION > portage/kde/kdegames/lskat/lskat-20120911.py PRE-CREATION > portage/kde/kdegames/palapeli/palapeli-20120911.py PRE-CREATION > portage/kde/kdegames/picmi/picmi-20120911.py PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106423/diff/ > > > Testing > ------- > > Yet to be tested on Windows. > > > Thanks, > > Laszlo Papp > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
