> On Nov. 7, 2012, 4:06 p.m., Kevin Krammer wrote: > > akonadi/socialutils/socialfeeditem.h, line 29 > > <http://git.reviewboard.kde.org/r/107235/diff/1/?file=94001#file94001line29> > > > > Move the include before the ones of Qt > > We include most local first then down the dependency stack. > > Position was fine for the forward declaration > > > > Actually, where in this header do you need KDateTime?
I don't in fact. Will revert this one. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107235/#review21563 ----------------------------------------------------------- On Nov. 7, 2012, 10:47 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107235/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2012, 10:47 a.m.) > > > Review request for KDEPIM, KDEPIM-Libraries and kdewin. > > > Description > ------- > > Thanks to bug 308763 we noticed couple issues, here's what this fixes: > > * Adds assignment operator > * Moves the private class to separate file > * Gets rid of PostReply class and replace it with SocialFeedItem itself > (they are practically the same) > * Fix typo/bad-copy-paste-job in _export.h file > > This should hopefully fix the windows build as well. > > > This addresses bug 308763. > http://bugs.kde.org/show_bug.cgi?id=308763 > > > Diffs > ----- > > akonadi/socialutils/libakonadisocialutils_export.h 106fbdc > akonadi/socialutils/socialfeeditem.h 2cbabe9 > akonadi/socialutils/socialfeeditem.cpp 6d6572b > akonadi/socialutils/socialfeeditem_p.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/107235/diff/ > > > Testing > ------- > > Tested with facebook resource, all compiles and works. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
