----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109417/#review28977 -----------------------------------------------------------
Ship it! looks good. I think you can commit directly to emerge in the future with out review request before. One note about kdevplatform: we haven't used kdevplatform lately, so kdevplatform might contain lots of bugs under windows. If you want to work on that, we can try and support you. - Patrick Spendrin On March 11, 2013, 1:27 p.m., Florian Eßer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109417/ > ----------------------------------------------------------- > > (Updated March 11, 2013, 1:27 p.m.) > > > Review request for kdewin, Patrick Spendrin and Patrick von Reth. > > > Description > ------- > > Running "emerge kdevplatform" on Win7 x64 / mingw64 failed with "zip not > recognized as an internal or external command, operable program or batch > file" somewhere along the build process ("[0%] Generating test_cpp.zip"). > > Adding zip to kdevplatform's buildDependencies fixed the problem. > > > Diffs > ----- > > portage/extragear/kdevplatform/kdevplatform-4.0.0.20100506.py bc8887e > > Diff: http://git.reviewboard.kde.org/r/109417/diff/ > > > Testing > ------- > > Worked for me. > > > Thanks, > > Florian Eßer > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
