> On July 6, 2014, 7:30 p.m., Patrick von Reth wrote: > > analitzaplot/CMakeLists.txt, line 15 > > <https://git.reviewboard.kde.org/r/119000/diff/1/?file=285137#file285137line15> > > > > Please enable it also for mingw, so WIN32 instead of MSVC. > > Nicolás Alvarez wrote: > MinGW needs `_BSD_SOURCE` or `_GNU_SOURCE` instead of > `_USE_MATH_DEFINES`. I'll post a new patch.
http://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/crt/math.h#l39 As you can see Patrick added it at least in the git version. - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119000/#review61747 ----------------------------------------------------------- On July 7, 2014, 12:38 a.m., Nicolás Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119000/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 12:38 a.m.) > > > Review request for KDE Edu and kdewin. > > > Repository: analitza > > > Description > ------- > > Set the needed macros for math.h to provide M_PI on Windows > > MSVC needs _USE_MATH_DEFINES: > See http://msdn.microsoft.com/en-us/library/4hwaceh6.aspx > > And MinGW needs either _BSD_SOURCE or _GNU_SOURCE. > > > Diffs > ----- > > analitzaplot/CMakeLists.txt 08e8990 > > Diff: https://git.reviewboard.kde.org/r/119000/diff/ > > > Testing > ------- > > Builds on MSVC2013 and MinGW4. > > > Thanks, > > Nicolás Alvarez > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
