> On Aug. 25, 2015, 7:41 a.m., Patrick Spendrin wrote: > > Hm, I'd prefer if we could fix the issue itself instead? Maybe we can also > > update gsl (if it hasn't happened yet).
GSL 1.16 is still the most recent version, but I can update the tag to point to the most recent commit from the AMPL repo. The error is this: ``` Linking C executable bin\cdf_test.exe gsl.lib(pow_int.c.obj) : error LNK2005: gsl_pow_3 already defined in gsl.lib(gamma_inc.c.obj) bin\cdf_test.exe : fatal error LNK1169: one or more multiply defined symbols found ``` I would also prefer the underlying issue be fixed. I looked into it, but the solution was not obvious to me. Maybe it has something to do with C inlining rules? The multiply defined function gsl_pow_3 is defined inline: https://github.com/ampl/gsl/blob/master/gsl_pow_int.h The function is in fact used in this file, where the compiler complains, thus gsl_pow_int.h must have been included somewhere: https://github.com/ampl/gsl/blob/master/specfunc/gamma_inc.c - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124881/#review84320 ----------------------------------------------------------- On Aug. 22, 2015, 3:43 p.m., Michael Abrahams wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124881/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2015, 3:43 p.m.) > > > Review request for kdewin. > > > Repository: emerge > > > Description > ------- > > Silences a linking error with multiply defined symbols in cdf/test.c in MSVC > 2015 > > > Diffs > ----- > > portage/win32libs/gsl/gsl-disable-testing-msvc.patch PRE-CREATION > portage/win32libs/gsl/gsl.py 8432312 > > Diff: https://git.reviewboard.kde.org/r/124881/diff/ > > > Testing > ------- > > > Thanks, > > Michael Abrahams > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
