----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125580/#review86661 -----------------------------------------------------------
portage/qt-libs/poppler/poppler-0.35.0-20151007.diff (lines 20 - 22) <https://git.reviewboard.kde.org/r/125580/#comment59654> Why do you guard it with '_MSC_VER >= 1900' here? The guard should be removed or added everywhere else. btw: The same patches are needed for msvc2013 too, so the guard should be at least '_MSC_VER >= 1800' for upstream - Christian Ehrlicher On Okt. 11, 2015, 1:39 nachm., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125580/ > ----------------------------------------------------------- > > (Updated Okt. 11, 2015, 1:39 nachm.) > > > Review request for kdewin, Albert Astals Cid and Pino Toscano. > > > Repository: emerge > > > Description > ------- > > I've had to put #include <algorithm> everywhere, not sure if it is a right > thing to do. > > > Diffs > ----- > > portage/qt-libs/poppler/poppler-0.35.0-20151007.diff PRE-CREATION > portage/qt-libs/poppler/poppler.py e26d35a > > Diff: https://git.reviewboard.kde.org/r/125580/diff/ > > > Testing > ------- > > > Thanks, > > Gleb Popov > >
_______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows
