----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129270/ -----------------------------------------------------------
(Updated oct. 31, 2016, 11:43 matin) Review request for Kdenlive. Changes ------- Added base class to Bool Parameter Repository: kdenlive Description (updated) ------- This is a first step towards a refactoring of the effects stack. Currently the different widgets do not share a base class and their creation based on the xml is a bit cluttered, with a lot of redundancies. The plan is to unify this by creating a proper factory method. I'll split the work into small and hopefully easy to review bits so that we make sure that no feature is lost on the way. Diffs (updated) ----- src/CMakeLists.txt 2814fa3 src/effectstack/CMakeLists.txt 80ae0d6 src/effectstack/parametercontainer.h 3b1b1b3 src/effectstack/parametercontainer.cpp ccec798 src/effectstack/widgets/abstractparamwidget.h PRE-CREATION src/effectstack/widgets/boolparamwidget.h PRE-CREATION src/effectstack/widgets/boolparamwidget.cpp PRE-CREATION src/effectstack/widgets/doubleparameterwidget.h 7c81a2e src/effectstack/widgets/doubleparameterwidget.cpp bf7f245 src/effectstack/widgets/draggablelabel.h PRE-CREATION src/effectstack/widgets/draggablelabel.cpp PRE-CREATION src/effectstack/widgets/listparamwidget.h PRE-CREATION src/effectstack/widgets/listparamwidget.cpp PRE-CREATION src/ui/boolval_ui.ui 5f22525 src/ui/listval_ui.ui 7bc1925 Diff: https://git.reviewboard.kde.org/r/129270/diff/ Testing ------- Tested with a mock project Thanks, alcinos alcinos
