https://bugs.kde.org/show_bug.cgi?id=315910
Laurent Montel <mon...@kde.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mon...@kde.org --- Comment #3 from Laurent Montel <mon...@kde.org> --- Better to put in reviewbord but ok. For me : std::string *fileToParse() seem logical. Perhaps add a "const"; => std::string *fileToParse() const; For other mem leak your fix seems good (but I didn't test it). For yacc language I don't know I don't know syntax but for me your patch seems good. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs