Send kea-dev mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.isc.org/mailman/listinfo/kea-dev
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of kea-dev digest..."
Today's Topics:
1. Re: Options and Relay Agent information (Francis Dupont)
2. Re: Options and Relay Agent information (Vadim Fedorenko)
3. Re: Options and Relay Agent information (Francis Dupont)
4. Re: Options and Relay Agent information (Marcin Siodelski)
----------------------------------------------------------------------
Message: 1
Date: Thu, 12 Nov 2015 12:12:10 +0000
From: Francis Dupont <[email protected]>
To: Marcin Siodelski <[email protected]>
Cc: Vadim Fedorenko <[email protected]>, [email protected]
Subject: Re: [kea-dev] Options and Relay Agent information
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"
I am afraid it won't be enough to use an unordered set (current
OptionCollection is a multimap keyed by the option code) as
th bug (*) required the relay info option to be the last one.
(*) it is a bug because there is no REQUIRE about option order.
Note the relay info option is added by the relay so I can understand
it is in general appended (RFC 3046 has a SHALL for last position or
just before the end option (code 255)). For the server it is only
a SHOULD for the last position (RFC 3046 2.2).
Regards
Francis Dupont <[email protected]>
PS: this needs its ticket but is easy to fix (LibDHCP::packOptions is
a 4 line routine).
------------------------------
Message: 2
Date: Thu, 12 Nov 2015 16:15:11 +0300
From: Vadim Fedorenko <[email protected]>
To: Francis Dupont <[email protected]>
Cc: [email protected]
Subject: Re: [kea-dev] Options and Relay Agent information
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
> I am afraid it won't be enough to use an unordered set (current
> OptionCollection is a multimap keyed by the option code) as
> th bug (*) required the relay info option to be the last one.
> (*) it is a bug because there is no REQUIRE about option order.
> Note the relay info option is added by the relay so I can understand
> it is in general appended (RFC 3046 has a SHALL for last position or
> just before the end option (code 255)). For the server it is only
> a SHOULD for the last position (RFC 3046 2.2).
It seems to me that SHOULD in RFC is for whole Option, not for the position.
And it could be read as SHOULD copy, and if it copies, that in the last
position.
I'll open ticket soon
--
Best regards,
Vadim
------------------------------
Message: 3
Date: Thu, 12 Nov 2015 13:29:24 +0000
From: Francis Dupont <[email protected]>
To: Vadim Fedorenko <[email protected]>
Cc: [email protected]
Subject: Re: [kea-dev] Options and Relay Agent information
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"
Vadim Fedorenko writes:
> It seems to me that SHOULD in RFC is for whole Option, not for the position.
> And it could be read as SHOULD copy, and if it copies, that in the last posit
> ion.
=> the RFC text is:
Servers SHOULD copy the Relay Agent Information
option as the last DHCP option in the response.
so IMHO the SHOULD is about the copy and the position.
> I'll open ticket soon
=> thanks
Francis Dupont <[email protected]>
------------------------------
Message: 4
Date: Thu, 12 Nov 2015 14:33:59 +0100
From: Marcin Siodelski <[email protected]>
To: Francis Dupont <[email protected]>
Cc: Vadim Fedorenko <[email protected]>, [email protected]
Subject: Re: [kea-dev] Options and Relay Agent information
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
On 12.11.2015 14:29, Francis Dupont wrote:
> Vadim Fedorenko writes:
> > It seems to me that SHOULD in RFC is for whole Option, not for the
> position.
> > And it could be read as SHOULD copy, and if it copies, that in the
> last posit
> > ion.
>
> => the RFC text is:
>
> Servers SHOULD copy the Relay Agent Information
> option as the last DHCP option in the response.
>
> so IMHO the SHOULD is about the copy and the position.
>
> > I'll open ticket soon
>
> => thanks
>
> Francis Dupont <[email protected]>
>
I strikes me that SHOULD doesn't warrant that server does it and that it
is feasible to ignore everything past this option. But, I think that
since the relays do what they do, we should make sure we put it at the end.
Marcin
------------------------------
_______________________________________________
kea-dev mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/kea-dev
End of kea-dev Digest, Vol 20, Issue 5
**************************************
