On Tue, Mar 17, 2009 at 02:41:36PM -0600, Shawn Emery wrote:
>
> Could someone please code review the following changes, as these changes
> are highly requested?
>
> Shawn.
> --
> Shawn M Emery wrote:
>>
>> Requesting a code review for the following fixes for:
>>
>> 6787343 kclient's site lookups fail in certain network environments
>> 6692646 kclient should output errors to stderr
>>
>> http://cr.opensolaris.org/~semery/6787343
33 function cleanup {
34 integer ret=$1
35
36 [[ -z $TMP_FILE ]] && exit $ret
37 kdestroy -q 1> $TMP_FILE 2>&1
38
39 [[ -z $TMPDIR ]] && exit $ret
40 rm -r $TMPDIR > /dev/null 2>&1
- I don't get this logic. If TMP_FILE isn't set then TMPDIR won't get
removed? Is this intended?
67 + typeset -ui10 a b c d
- Why -u for i10? -u converts characters to uppercase but this
shouldn't be applicable to base 10.
Rest looks okay.
--
Will Fiveash
Sun Microsystems Inc.
http://opensolaris.org/os/project/kerberos/
