On Fri, Jun 19, 2009 at 01:51:04PM -0500, Nicolas Williams wrote:
> On Wed, Jun 10, 2009 at 10:09:32PM -0700, Glenn Barry wrote:
> > 6791302 RPCSEC_GSS svc should be able to handle a misbehaving client
> > 
> > http://cr.opensolaris.org/~gtb/6791302/webrev-O/

 - usr/src/uts/common/rpc/sec_gss/svc_rpcsec_gss.c:239-240,242-245

   Hmmm, rpc_msg_dup/free() and svc_clone_*() should be in a header
   file, no?


 - usr/src/uts/common/rpc/sec_gss/svc_rpcsec_gss.c:248-256,998-995

   Major abstraction violation here.  Shouldn't this be a private detail
   of svc_clone_link()?  IMO: yes.



Reply via email to