On Tue, 2009-01-20 at 13:14 -0500, Peter Shoults wrote: > >> 6784485 keys for kadmind princs should be created with all supported > >> enc-types > >> http://cr.opensolaris.org/~mbp/6784485-enctypes_for_default_kadmin_princs/ > >> > > 1) Should we be calling > > krb5_free_ktypes(context, enctype); > > IF we failed the malloc() on line 321?
Yup, nice catch. I'll make the change. > > 2) Line 341 of new file - How are you determining you are only creating > keys with "Normal" enctypes? Normal _salt_types. Line 330 a "normal" salttype is created. This salttype is used when creating the keys. See line 344 where the salttype is being set. > > Otherwise looks good. Thanks, -M
