Mark Phalan wrote: > On Thu, 2008-04-10 at 09:56 -0400, Peter Shoults wrote: > >> My comments...well - only one... >> >> usr/src/cmd/krb5/ldap_util/kdb5_ldap_services.c - line 586 - You used me >> instead of progname. I think you did not mean to do that as it breaks >> from everything else you have done. >> > > Actually, I meant to do it :) > > The "me" here was previously set to "argv[0]". The rest of the function > uses already used "me" for error messages. "me" was was originally set > to "argv[0]" on line 508 but after my changes is set to "progname". If > you take a look at that function ( db5_ldap_modify_service()) you'll see > it's more consistent now. > > Cheers, > > -M > >
Ok - I see what you mean - so I am good. No other issues I could find. pete
