On Thu, 29 Aug 2013, Julien ÉLIE wrote:

Hi,

Building krb5 1.11.3 fails on NetBSD 5.1 with the following error:

/home/iulius/autobuild/bin/gcc-4.8.1/bin/gcc  -fPIC -DSHARED   -I../../../include 
-I../../../include -I. -I./../builtin -DKRB5_DEPRECATED=1 -DKRB5_PRIVATE  -g -O2 -Wall 
-Wcast-align -Wshadow -Wmissing-prototypes -pedantic -Wno-format-zero-length -Woverflow 
-Wstrict-overflow -Wmissing-format-attribute -Wmissing-prototypes -Wreturn-type 
-Wmissing-braces -Wparentheses -Wswitch -Wunused-function -Wunused-label 
-Wunused-variable -Wunused-value -Wunknown-pragmas -Wsign-compare -Werror=uninitialized 
-Werror=declaration-after-statement -Werror=variadic-macros 
-Werror-implicit-function-declaration -pthread -c aead.c -o aead.so.o && mv -f 
aead.so.o aead.so
In file included from ../../../include/k5-int.h:185:0,
                from crypto_int.h:33,
                from aead.c:27:
../../../include/k5-trace.h:93:20: error: anonymous variadic macros were 
introduced in C99 [-Werror=variadic-macros]
#define TRACE(ctx, ...)                                        \
                   ^
cc1: some warnings being treated as errors
make[3]: *** [aead.so] Error 1



Would it be possible to fix the issue for the next krb5 release?
(Maybe by not using the gcc "-Werror=variadic-macros" flag?)

Commit d211001ba17fddfb952beb00118dc5c7e598355e on git master has resolved the issue (I saw it on FreeBSD as well, though only as a warning). It does not appear to be marked for pullup to the 1.11 branch, though; I'll look at whether that's reasonable to do.

-Ben Kaduk
________________________________________________
Kerberos mailing list           [email protected]
https://mailman.mit.edu/mailman/listinfo/kerberos

Reply via email to