Oh, no bad at all :). Just as you did, I did think about coming up some enum or the like that's extensible because I wanted to share common options and related codes between krb client side and kdc server side. The overhead was not paid so I gave it up.
Regards, Kai -----Original Message----- From: Emmanuel Lécharny [mailto:elecha...@gmail.com] Sent: Friday, November 27, 2015 12:06 AM To: kerby@directory.apache.org Subject: Re: Kerby client library refactoring Le 26/11/15 12:44, Zheng, Kai a écrit : > Thanks Emmanuel for the feedback and sorry for the late response as focusing > on the ASN1 things. > >>> If those elements are going to be Enum, keep in mind that you can inherit >>> from another enum. > In current Kerby codes, for options and flags, we favor using the Java enum > keyword as a better practice than interfaces of constants. > The drawback is that it's not extensible, or in other words, an enum can't > extend another enum. Ahhh, yeah, my bad... Not a big issue though.