On Thu, 2008-02-07 at 13:14 +0100, [EMAIL PROTECTED] wrote: > We've had several issues with 2.16 when it comes to > AbstractVelocityTemplateTag and the findLayout function. As a result of this > I've mildly modified it to return NULL if the datamodel is problematic (i.e. > datamodel.getPage().getCurrentTab() oftes returns NULL, as do > datamodel.getParameters()). > > I'm not sure of the consequenses of this, can you think of anything that > breaks because of this? It does seem to have solved the main issues being a > intern error 404 site being shown, and I've been unable to find any errors > caused by this.
It should be acceptable that findLayout(..) returns null. This would be expected on pages that don't use datamodel or datamodel.page, eg 40x or 50x pages. The method is only intended to find an appropriate layout when one exists. (This should definitely be documented. Indeed it is compulsory to javadoc valid null returns). ~mck -- "Those people who think they know everything are a great annoyance to those of us who do." Isaac Asimov | Homepage - www.wever.org | Sesam Search Engine - www.sesam.no |
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Kernel-development mailing list [email protected] http://sesat.no/mailman/listinfo/kernel-development
