--- moved to [email protected] ---
> I found a disturbing number of objects being created.
>
> This numbers show how many objects being created of the top classes:
>
> no.sesat.search.query.token.TokenEvaluationEngineImpl$1 192629
> no.sesat.search.query.token.JepEvaluatorFactory$1 137061
> no.sesat.search.query.token.RegExpEvaluatorFactory$1 137057
>
> Total = 470.706
Errr, this doesn't look like the total to me :-/
I gather your top numbers are for 1000 requests.
> This is the result after one search: "1 2 3 4 5 6 7 8 9 10 11 12 13 14 15"
> This code's purpose is basically to pass the Site or the FactoryName wrapped
> in a context object. But instead of creating the context object each time we
> could store them in the corresponding Site or EvaluatorType. Then they will
> only be created ones pr. Site/EvaluatorType instance.
Got an example patch?
I presume you mean something like adding
"Context getParentSiteContext()"
to AbstractEvaluatorFactory?
> The total object count after this code changed dropped from 470.706 to 3.959,
> which is a dramatic drop.
>
> for a more sane search "finn sofa" we get this results. (Search repeated)
>
> 1. 14.185 to 1.095 (init + search)
> 2. 17.695 to 1.454
> 3 26.961 to 1.840
How are you getting decimal places with a fixed search?
Could you repeat your instrumentation against a warmed up application please.
> why do we need to call getEvaluator close to half a million
> times for one "large" search. :-)
yes i'd like to know this too :-)
This code has changed dramatically in 2.18 with the introduction of the
Sesat Evaluator API. Infact the two anonymous classes, and the
performance gain, you've found here is only applicable to 2.18 code
unfortunately. But thanks for cleaning up my new code :-)
> new BaseContext() {
> public String getEvaluatorFactoryClassName() {
I've fixed this one with r6757
~mck
--
"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the Universe trying to
produce bigger and better idiots. So far, the Universe is winning." Rich
Cook
| semb.wever.org | sesat.no | sesam.no |
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Kernel-development mailing list [email protected] http://sesat.no/mailman/listinfo/kernel-development
