** Changed in: ubuntu-fan (Ubuntu Zesty)
Importance: Undecided => Medium
** Changed in: ubuntu-fan (Ubuntu Zesty)
Status: New => Fix Committed
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to ubuntu-fan in Ubuntu.
https://bugs.launchpad.net/bugs/1691485
Title:
fanatic disable-fan fails without docker installed
Status in ubuntu-fan package in Ubuntu:
Fix Committed
Status in ubuntu-fan source package in Zesty:
Fix Committed
Bug description:
Release: 17.04/Zesty
Version: 0.12.2
When disabling fan, the code tries to check whether docker is
configured. However that test is attempting to decide which docker
version is installed (in order to handle the new network options).
This fails but is incorrectly evaluated as docker being configured.
And that prevents fan from being de-configured.
Fix: Test for docker being installed and if not return false to the
configured check.
SRU Justification:
Impact: The function which does docker config updates/tests currently
does not check for the presence of the docker command itself. And
while there are error messages to stderr a call to check for fan being
configured for docker accidentally results in returning true.
Fix: Adding a check for the docker command being present early in the
function and return an error in that case (which is a false in the is-
docker-configured case). Since the function should really always fail
if there is no docker present the risk of regressions should be low.
Testcase:
- [docker is not installed]
- fanatic enable-fan ...
- fanatic disable-fan ...
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-fan/+bug/1691485/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
