[VERIFICATION ZESTY]

# rmadison
linux-image-4.10.0-41-generic | 4.10.0-41.45         | zesty-proposed  | amd64, 
arm64, armhf, i386, ppc64el, s390x


# lsb_release -r
Release:        17.04


# apt-get changelog linux-image-4.10.0-41-generic | grep -A2 1729119
  * NVMe timeout is too short (LP: #1729119)
    - nvme: update timeout module parameter type


# uname -r
4.10.0-41-generic


I had no nvme drive at my disposal but the following test should suffice :

# lsmod | grep -i nvme

# modprobe nvme_core io_timeout=123456

# lsmod | grep -i nvme
nvme_core              57344  0

# cat /sys/module/nvme_core/parameters/io_timeout 
123456


** Note that it doesn't seems to work at runtime (if the module is already 
loaded). It only works when the module haven't been previously loaded for some 
reasons **

But I don't see this as a blocker for the current SRU.

root@zesty:~# lsmod | grep -i nvme
nvme_core              57344  0

root@zesty:~# modprobe nvme_core io_timeout=123457

root@zesty:~# cat /sys/module/nvme_core/parameters/io_timeout 
123456

- Eric



** Tags removed: verification-needed-zesty
** Tags added: verification-done-zesty

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-aws in Ubuntu.
https://bugs.launchpad.net/bugs/1729119

Title:
  NVMe timeout is too short

Status in linux package in Ubuntu:
  Confirmed
Status in linux-aws package in Ubuntu:
  Fix Released
Status in linux source package in Trusty:
  Fix Committed
Status in linux-aws source package in Trusty:
  New
Status in linux source package in Xenial:
  Fix Committed
Status in linux-aws source package in Xenial:
  Fix Released
Status in linux source package in Zesty:
  Fix Committed
Status in linux-aws source package in Zesty:
  Invalid
Status in linux source package in Artful:
  Fix Committed
Status in linux-aws source package in Artful:
  Invalid

Bug description:
  [SRU Justification]

  [Impact]
  Some NVMe operations time out too quickly. The module parameters allow the 
timeouts to be extended, but only up to 255s, as the counters are bytes.

  [Fix]
  The underlying parameters are unsigned ints, so make the module parameters 
unsigned ints too, by picking patch 
http://lists.infradead.org/pipermail/linux-nvme/2017-September/012701.html

  (Trusty specific) This also requires picking the patch that converts
  the constant into a parameter, which is a clean cherry-pick.

  [Regression Potential]
  (X/Z/A) Very limited: only types of module parameters are changing, the patch 
is easily reviewable.

  (Trusty specific) Limited: a module parameter is added and its type is
  changed. The patches are easily reviewable.

  [Testing]
  (Trusty only) Boot tested on a c5.large instance on AWS which uses
  NVMe to boot. Verified that the system still boots with the patches,
  and that a timeout of 123456s is permitted.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1729119/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to