From: Willem de Bruijn <[email protected]> Date: Mon, 11 Dec 2017 16:56:56 -0500
> On Mon, Dec 11, 2017 at 4:44 PM, Greg Kroah-Hartman > <[email protected]> wrote: >> On Mon, Dec 11, 2017 at 04:25:26PM -0500, Willem de Bruijn wrote: >>> Note that UFO was removed in 4.14 and that skb_warn_bad_offload >>> can happen for various types of packets, so there may be multiple >>> independent bug reports. I'm investigating two other non-UFO reports >>> just now. >> >> Meta-comment, now that UFO is gone from mainline, I'm wondering if I >> should just delete it from 4.4 and 4.9 as well. Any objections for >> that? I'd like to make it easy to maintain these kernels for a while, >> and having them diverge like this, with all of the issues around UFO, >> seems like it will just make life harder for myself if I leave it in. >> >> Any opinions? > > Some of that removal had to be reverted with commit 0c19f846d582 > ("net: accept UFO datagrams from tuntap and packet") for VM live > migration between kernels. > > Any backports probably should squash that in at the least. Just today > another thread discussed that that patch may not address all open > issues still, so it may be premature to backport at this point. > http://lkml.kernel.org/r/<[email protected]> I would probably discourage backporting the UFO removal, at least for now. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1715609 Title: kernel warning: skb_warn_bad_offload Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Zesty: In Progress Bug description: Since upgrading to kernel version 4.10.0-33.37, we're seeing a lot of call traces triggered by skb_warn_bad_offload in the syslog. Regression introduced when fixing this bug? https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1705447 kernel: [570943.494444] ------------[ cut here ]------------ kernel: [570943.494448] WARNING: CPU: 3 PID: 21982 at /build/linux-hwe-YA6IuF/linux-hwe-4.10.0/net/core/dev.c:2576 skb_warn_bad_offload+0xd1/0x120 kernel: [570943.494450] e1000e: caps=(0x00000030002149a9, 0x0000000000000000) len=1701 data_len=1659 gso_size=1480 gso_type=2 ip_summed=0 kernel: [570943.494451] Modules linked in: udp_diag tcp_diag inet_diag echainiv authenc xfrm4_mode_tunnel xt_state binfmt_misc veth xfrm_user xfrm4_tunnel tunnel4 ipcomp xfrm_ipcomp esp4 ah4 af_key xfrm_algo bridge stp llc iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat ipt_REJECT nf_reject_ipv4 xt_tcpudp nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack iptable_filter ip_tables x_tables intel_rapl x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm ppdev irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc aesni_intel aes_x86_64 crypto_simd glue_helper cryptd intel_cstate intel_rapl_perf hci_uart ie31200_edac btbcm edac_core intel_pch_thermal btqca serio_raw btintel bluetooth parport_pc parport mac_hid intel_lpss_acpi acpi_pad intel_lpss autofs4 kernel: [570943.494500] btrfs raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor raid6_pq libcrc32c raid0 multipath linear raid1 e1000e psmouse ptp ahci pps_core libahci wmi pinctrl_sunrisepoint i2c_hid video pinctrl_intel hid fjes kernel: [570943.494524] CPU: 3 PID: 21982 Comm: charon Tainted: G W 4.10.0-33-generic #37~16.04.1-Ubuntu kernel: [570943.494524] Hardware name: ... kernel: [570943.494525] Call Trace: kernel: [570943.494541] <IRQ> kernel: [570943.494544] dump_stack+0x63/0x90 kernel: [570943.494545] __warn+0xcb/0xf0 kernel: [570943.494546] warn_slowpath_fmt+0x5f/0x80 kernel: [570943.494547] ? ___ratelimit+0xa2/0xf0 kernel: [570943.494549] skb_warn_bad_offload+0xd1/0x120 kernel: [570943.494550] __skb_gso_segment+0x17d/0x190 kernel: [570943.494564] validate_xmit_skb+0x14f/0x2a0 kernel: [570943.494565] validate_xmit_skb_list+0x43/0x70 kernel: [570943.494567] sch_direct_xmit+0x16b/0x1c0 kernel: [570943.494568] __dev_queue_xmit+0x47e/0x690 kernel: [570943.494569] dev_queue_xmit+0x10/0x20 kernel: [570943.494570] ip_finish_output2+0x27a/0x370 kernel: [570943.494571] ip_finish_output+0x176/0x270 kernel: [570943.494571] ip_output+0x76/0xe0 kernel: [570943.494572] ? ip_fragment.constprop.49+0x80/0x80 kernel: [570943.494573] ip_forward_finish+0x43/0x70 kernel: [570943.494574] ip_forward+0x385/0x460 kernel: [570943.494575] ? ip_frag_mem+0x50/0x50 kernel: [570943.494575] ip_rcv_finish+0x11b/0x400 kernel: [570943.494576] ip_rcv+0x28b/0x3a0 ... kernel: [570943.494632] ---[ end trace f01d0adcc1256afe ]--- To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1715609/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
