I'm not sure I understand what's going on here, so I'll take the risk
that I'm describing the obvious:

@UDEV_BIN_DIR@ is a cmake parameter that is replaced by cmake with the path it 
reads from pkgconfig. See here:
https://github.com/intel/thunderbolt-software-user-space/blob/master/CMakeLists.txt#L10
If this is the wrong location:
1. UDEV_BIN_DIR can be set manually while running cmake (or using 
ccmake/cmake-gui).
2. If there is a better way to detect the distro-specific correct location for 
udev dirs, I'd like to fix it upstream.

Anyway, copy of the original .rules.in files instead of using the
resulted .rules file seems strange to me.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to thunderbolt-tools in Ubuntu.
Matching subscriptions: Kernel Packages
https://bugs.launchpad.net/bugs/1761757

Title:
  use correct path for tbtacl in udev rules

Status in thunderbolt-tools package in Ubuntu:
  Fix Released

Bug description:
  ./thunderbolt-tools_0.9.3-1_amd64/lib/udev/rules.d/tbtacl.rules:
  # Thunderbolt udev rules for ACL (device auto approval)
  SUBSYSTEM=="thunderbolt" ENV{DEVTYPE}=="thunderbolt_device" ACTION=="add" 
ATTR{authorized}=="0" RUN+="@UDEV_BIN_DIR@/tbtacl add $devpath"
  SUBSYSTEM=="thunderbolt" ENV{DEVTYPE}=="thunderbolt_device" ACTION=="change" 
ATTR{authorized}!="0" RUN+="@UDEV_BIN_DIR@/tbtacl change $devpath"

  should changed to fix up @UDEV_BIN_DIR@ to be:

  SUBSYSTEM=="thunderbolt" ENV{DEVTYPE}=="thunderbolt_device" ACTION=="add"    
ATTR{authorized}=="0" RUN+="/lib/udev/tbtacl add    $devpath"
  SUBSYSTEM=="thunderbolt" ENV{DEVTYPE}=="thunderbolt_device" ACTION=="change" 
ATTR{authorized}!="0" RUN+="/lib/udev/tbtacl change $devpath"

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/thunderbolt-tools/+bug/1761757/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to