On 05/02/2018 06:41 AM, Rafael J. Wysocki wrote: > On Tue, May 1, 2018 at 9:55 PM, Bjorn Helgaas <helg...@kernel.org> wrote: >> On Tue, May 01, 2018 at 10:34:29AM +0200, Rafael J. Wysocki wrote: >>> On Mon, Apr 30, 2018 at 4:22 PM, Joseph Salisbury >>> <joseph.salisb...@canonical.com> wrote: >>>> On 04/16/2018 11:58 AM, Rafael J. Wysocki wrote: >>>>> On Mon, Apr 16, 2018 at 5:31 PM, Joseph Salisbury >>>>> <joseph.salisb...@canonical.com> wrote: >>>>>> On 04/13/2018 05:34 PM, Rafael J. Wysocki wrote: >>>>>>> On Fri, Apr 13, 2018 at 7:56 PM, Joseph Salisbury >>>>>>> <joseph.salisb...@canonical.com> wrote: >>>>>>>> Hi Rafael, >>>>>>>> >>>>>>>> A kernel bug report was opened against Ubuntu [0]. After a kernel >>>>>>>> bisect, it was found that reverting the following two commits resolved >>>>>>>> this bug: >>>>>>>> >>>>>>>> 0ce3fcaff929 ("PCI / PM: Restore PME Enable after config space >>>>>>>> restoration") >>>>>>>> 0847684cfc5f("PCI / PM: Simplify device wakeup settings code") >>>>>>>> >>>>>>>> This is a regression introduced in v4.13-rc1 and still exists in >>>>>>>> mainline. The bug causes the battery to drain when the system is >>>>>>>> powered down and unplugged, which does not happed prior to these two >>>>>>>> commits. >>>>>>> What system and what do you mean by "powered down"? How much time >>>>>>> does it take for the battery to drain now? >>>>>> By powered down, the bug reporter is saying physically powered off and >>>>>> unplugged. The system is a HP laptop: >>>>>> >>>>>> dmi.chassis.vendor: HP >>>>>> dmi.product.family: 103C_5335KV HP Notebook >>>>>> dmi.product.name: HP Notebook >>>>>> vendor_id : GenuineIntel >>>>>> cpu family : 6 >>>>>> >>>>>> >>>>>>>> The bisect actually pointed to commit de3ef1e, but reverting >>>>>>>> these two commits fixes the issue. >>>>>>>> >>>>>>>> I was hoping to get your feedback, since you are the patch author. Do >>>>>>>> you think gathering any additional data will help diagnose this issue, >>>>>>>> or would it be best to submit a revert request? >>>>>>> First, reverting these is not an option or you will break systems >>>>>>> relying on them now. 4.13 is three releases back at this point. >>>>>>> >>>>>>> Second, your issue appears to be related to the suspend/shutdown path >>>>>>> whereas commit 0ce3fcaff929 is mostly about resume, so presumably the >>>>>>> change in pci_enable_wake() causes the problem to happen. Can you try >>>>>>> to revert this one alone and see if that helps? >>>>>> A test kernel with commits 0ce3fcaff929 and de3ef1eb1cd0 reverted was >>>>>> tested. However, the test kernel still exhibited the bug. >>>>> So essentially the bisection result cannot be trusted. >>>> We performed some more testing and confirmed just a revert of the >>>> following commit resolves the bug: >>>> >>>> 0847684cfc5f0 ("PCI / PM: Simplify device wakeup settings code") >>> Thanks for confirming this! >>> >>>> Can you think of any suggestions to help debug further? >>> The root cause of the regression is likely the change in >>> pci_enable_wake() removing the device_may_wakeup() check from it. >>> >>> Probably, one of the drivers in the platform calls pci_enable_wake() >>> directly from its ->shutdown() callback and that causes the device to >>> be set up for system wakeup which in turn causes the power draw while >>> the system is off to increase. >>> >>> I would look at the PCI drivers used on that platform to find which of >>> them call pci_enable_wake() directly from ->shutdown() and I would >>> make these calls conditional on device_may_wakeup(). >> I took a quick look with >> >> git grep -E "pci_enable_wake\(.*[^0]\);|device_may_wakeup" >> >> and didn't notice any pci_enable_wake() callers that called >> device_may_wakeup() first. > I've just look at a bunch of network drivers doing that. > > It looks like I may need to restore __pci_enable_wake() with an extra > "runtime" argument for internal use. > > Joseph, can you ask the reporter to test the Bjorn's patch, please?
Yes, I'll get him a test kernel and respond with the results. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1745646 Title: Battery drains when laptop is off (shutdown) Status in Linux: Unknown Status in acpi package in Ubuntu: Confirmed Status in linux package in Ubuntu: In Progress Status in acpi source package in Artful: New Status in linux source package in Artful: In Progress Status in acpi source package in Bionic: Confirmed Status in linux source package in Bionic: In Progress Bug description: I am using hp AY008tx laptop , and many other laptop users (HP) are also facing the same issue . The problem don't occur when i install windows 10 . Now, only ubuntu is installed. i am using latest bios insyde20 rev 5.(latest) WOL disabled and no usb device connected checked my battery . it don't happen when i remove battery and plug it again after shutdown. tried laptop_mode_tools and tpl too ProblemType: Bug DistroRelease: Ubuntu 16.04 Package: linux-image-4.13.0-31-generic 4.13.0-31.34~16.04.1 ProcVersionSignature: Ubuntu 4.13.0-31.34~16.04.1-generic 4.13.13 Uname: Linux 4.13.0-31-generic x86_64 NonfreeKernelModules: wl ApportVersion: 2.20.1-0ubuntu2.15 Architecture: amd64 CurrentDesktop: Unity Date: Fri Jan 26 22:50:53 2018 InstallationDate: Installed on 2018-01-25 (1 days ago) InstallationMedia: Ubuntu 16.04.3 LTS "Xenial Xerus" - Release amd64 (20170801) SourcePackage: linux-hwe UpgradeStatus: No upgrade log present (probably fresh install) --- ApportVersion: 2.20.1-0ubuntu2.15 Architecture: amd64 AudioDevicesInUse: USER PID ACCESS COMMAND /dev/snd/controlC0: gopal 2391 F.... pulseaudio DistroRelease: Ubuntu 16.04 HibernationDevice: RESUME=UUID=0bf03973-049c-480e-9e14-7596bf68d994 InstallationDate: Installed on 2018-01-25 (1 days ago) InstallationMedia: Ubuntu 16.04.3 LTS "Xenial Xerus" - Release amd64 (20170801) Lsusb: Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub Bus 001 Device 003: ID 04f2:b56c Chicony Electronics Co., Ltd Bus 001 Device 002: ID 0a5c:216d Broadcom Corp. Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub MachineType: HP HP Notebook NonfreeKernelModules: wl Package: linux (not installed) ProcEnviron: LANGUAGE=en_IN:en TERM=xterm-256color PATH=(custom, no user) LANG=en_IN SHELL=/bin/bash ProcFB: 0 inteldrmfb ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-4.13.0-31-generic.efi.signed root=UUID=3a4ef59e-130a-4ce0-92d3-2fc42f5c9f59 ro quiet splash vt.handoff=7 ProcVersionSignature: Ubuntu 4.13.0-31.34~16.04.1-generic 4.13.13 PulseList: Error: command ['pacmd', 'list'] failed with exit code 1: Home directory not accessible: Permission denied No PulseAudio daemon running, or not running as session daemon. RelatedPackageVersions: linux-restricted-modules-4.13.0-31-generic N/A linux-backports-modules-4.13.0-31-generic N/A linux-firmware 1.157.15 Tags: xenial Uname: Linux 4.13.0-31-generic x86_64 UpgradeStatus: No upgrade log present (probably fresh install) UserGroups: _MarkForUpload: True dmi.bios.date: 11/01/2017 dmi.bios.vendor: Insyde dmi.bios.version: F.40 dmi.board.asset.tag: Type2 - Board Asset Tag dmi.board.name: 81EC dmi.board.vendor: HP dmi.board.version: 61.58 dmi.chassis.type: 10 dmi.chassis.vendor: HP dmi.chassis.version: Chassis Version dmi.modalias: dmi:bvnInsyde:bvrF.40:bd11/01/2017:svnHP:pnHPNotebook:pvrType1ProductConfigId:rvnHP:rn81EC:rvr61.58:cvnHP:ct10:cvrChassisVersion: dmi.product.family: 103C_5335KV HP Notebook dmi.product.name: HP Notebook dmi.product.version: Type1ProductConfigId dmi.sys.vendor: HP To manage notifications about this bug go to: https://bugs.launchpad.net/linux/+bug/1745646/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp