commit ab1068d6866e28bf6427ceaea681a381e5870a4a Author: Hao Wei Tee <ange...@in04.sg> Date: Tue May 29 10:25:17 2018 +0300
iwlwifi: pcie: compare with number of IRQs requested for, not number of CPUs When there are 16 or more logical CPUs, we request for `IWL_MAX_RX_HW_QUEUES` (16) IRQs only as we limit to that number of IRQs, but later on we compare the number of IRQs returned to nr_online_cpus+2 instead of max_irqs, the latter being what we actually asked for. This ends up setting num_rx_queues to 17 which causes lots of out-of-bounds array accesses later on. Compare to max_irqs instead, and also add an assertion in case num_rx_queues > IWM_MAX_RX_HW_QUEUES. This fixes https://bugzilla.kernel.org/show_bug.cgi?id=199551 Fixes: 2e5d4a8f61dc ("iwlwifi: pcie: Add new configuration to enable MSIX") Signed-off-by: Hao Wei Tee <ange...@in04.sg> Tested-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> Signed-off-by: Kalle Valo <kv...@codeaurora.org> -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1805088 Title: iwlwifi fails to work on 16 or more logical CPUs machines Status in linux package in Ubuntu: In Progress Bug description: [Impact] Got dmesg kernel BUG while loading iwlwifi driver on machines which has 16 or more logical CPUs kernel: RIP: 0010:iwl_pcie_rxq_alloc_rbs+0x1d0/0x1f0 [iwlwifi] And it leads to wifi can't scan any APs, and leads to system hangs while suspending. [Fix] Below commit contained in v4.17 fix the issue. ab1068d6866e iwlwifi: pcie: compare with number of IRQs requested for, not number of CPUs [Regression Potential] Low. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1805088/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp