the case I tested:
install the dkms which already patched (also can be found in my ppa[1])
1. install a dkms which for a kernel module system already installed.
e.g. ath10k of my testing ppa : [1] 
1.1. the dkms can be installed well.

2. install a dkms which has OBSOLETE_BY and FORCE
e.g.ath10k of my testing ppa : [1] (source code in [2])
 + the target dkms defined OBSOLETE_BY and FORCE
   - OBSOLETE_BY="4.15.0-1033": 
https://git.launchpad.net/~alextu/+git/oem-wifi-qualcomm-ath10k-lp1803647-4.15-dkms/tree/oem-wifi-qualcomm-ath10k-lp1803647-4.15/dkms.conf?h=lp1838245#n8
   - 
https://git.launchpad.net/~alextu/+git/oem-wifi-qualcomm-ath10k-lp1803647-4.15-dkms/tree/oem-wifi-qualcomm-ath10k-lp1803647-4.15.force?h=lp1838245
 + user install dkms on a system which installed kernel version less than 
OBSOLETE_BY and another kernel higher than OBSOLETE_BY
  - in my system there're 2 kernels 4.15.0-1030 and 4.15.0-1045
 + the dkms can be installed well with kernel 4.15.0-1030, and not be installed 
with 4.15.0-1045

also attached the log came from patched dkms script during install dkms
[2]

[1]:https://code.launchpad.net/~alextu/+archive/ubuntu/dkms-2.3-lp1838245
[2]:https://code.launchpad.net/~alextu/+git/oem-wifi-qualcomm-ath10k-lp1803647-4.15-dkms/+ref/lp1838245

** Description changed:

- Building a kernel module using dkms in Linux Mint 19.1 shows the
- following error:
+ 
+ update for SRU process:
+ [Impact]
+ 1. dkms script is missing function find_module
+ 2. priority of OBSOLETE_BY should higher than "force". #89  
https://github.com/dell/dkms/issues/89
+ 
+ [Test case]
+ install the dkms which already patched (also can be found in my ppa[1])
+ 1. install a dkms which for a kernel module system already installed.
+ e.g. ath10k of my testing ppa : [1] 
+ 1.1. the dkms can be installed well.
+ 
+ 2. install a dkms which has OBSOLETE_BY and FORCE
+ e.g.ath10k of my testing ppa : [1] (source code in [2])
+  - the target dkms defined OBSOLETE_BY and FORCE
+  - user install dkms on a system which installed kernel version less than 
OBSOLETE_BY and another kernel higher than OBSOLETE_BY
+  - the dkms can be installed well.
+ 
+ [Regression potential]
+ medium as it touched the version sanity. This change correct the code logic 
and land one more change from upstream as well.
+ The logic has been verified by #5 and me.
+ 
+ ------------------------------------------------------------------------
+ Building a kernel module using dkms in Linux Mint 19.1 shows the following 
error:
  
  Running module version sanity check.
  /usr/sbin/dkms: Zeile 784: find_module: Befehl nicht gefunden
  modinfo: ERROR: missing module or filename.
  
  Checking the file the function is indeed missing and another user
  confirmed, that it was removed at some point:
  https://github.com/linuxmint/linuxmint/issues/142
  
  Possible solution: Readd
  
  find_module()
  {
-     # tree = $1
-     # module = $2
-     find "$1" -name "$2$module_uncompressed_suffix" -o -name 
"$2$module_suffix" -type f
-     return $?
+     # tree = $1
+     # module = $2
+     find "$1" -name "$2$module_uncompressed_suffix" -o -name 
"$2$module_suffix" -type f
+     return $?
  }
  
  as found in https://github.com/dell/dkms/blob/master/dkms

** Attachment added: "install-ath10k.log"
   
https://bugs.launchpad.net/ubuntu/+source/dkms/+bug/1838245/+attachment/5280259/+files/install-ath10k.log

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to dkms in Ubuntu.
https://bugs.launchpad.net/bugs/1838245

Title:
  dkms script is missing function find_module

Status in DKMS:
  In Progress
Status in dkms package in Ubuntu:
  Confirmed

Bug description:
  
  update for SRU process:
  [Impact]
  1. dkms script is missing function find_module
  2. priority of OBSOLETE_BY should higher than "force". #89  
https://github.com/dell/dkms/issues/89

  [Test case]
  install the dkms which already patched (also can be found in my ppa[1])
  1. install a dkms which for a kernel module system already installed.
  e.g. ath10k of my testing ppa : [1] 
  1.1. the dkms can be installed well.

  2. install a dkms which has OBSOLETE_BY and FORCE
  e.g.ath10k of my testing ppa : [1] (source code in [2])
   - the target dkms defined OBSOLETE_BY and FORCE
   - user install dkms on a system which installed kernel version less than 
OBSOLETE_BY and another kernel higher than OBSOLETE_BY
   - the dkms can be installed well.

  [Regression potential]
  medium as it touched the version sanity. This change correct the code logic 
and land one more change from upstream as well.
  The logic has been verified by #5 and me.

  ------------------------------------------------------------------------
  Building a kernel module using dkms in Linux Mint 19.1 shows the following 
error:

  Running module version sanity check.
  /usr/sbin/dkms: Zeile 784: find_module: Befehl nicht gefunden
  modinfo: ERROR: missing module or filename.

  Checking the file the function is indeed missing and another user
  confirmed, that it was removed at some point:
  https://github.com/linuxmint/linuxmint/issues/142

  Possible solution: Readd

  find_module()
  {
      # tree = $1
      # module = $2
      find "$1" -name "$2$module_uncompressed_suffix" -o -name 
"$2$module_suffix" -type f
      return $?
  }

  as found in https://github.com/dell/dkms/blob/master/dkms

To manage notifications about this bug go to:
https://bugs.launchpad.net/dkms/+bug/1838245/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to