We certainly want this:
commit 71c751f2a43fa03fae3cf5f0067ed3001a397013
Author: Mark Rutland <[email protected]>
Date: Mon Apr 23 11:41:33 2018 +0100
arm64: add sentinel to kpti_safe_list
We're missing a sentinel entry in kpti_safe_list. Thus
is_midr_in_range_list()
can walk past the end of kpti_safe_list. Depending on the contents of
memory,
this could erroneously match a CPU's MIDR, cause a data abort, or other bad
outcomes.
Add the sentinel entry to avoid this.
Fixes: be5b299830c63ed7 ("arm64: capabilities: Add support for checks based
on a list of MIDRs")
Signed-off-by: Mark Rutland <[email protected]>
Reported-by: Jan Kiszka <[email protected]>
Tested-by: Jan Kiszka <[email protected]>
Reviewed-by: Suzuki K Poulose <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Suzuki K Poulose <[email protected]>
Cc: Will Deacon <[email protected]>
Signed-off-by: Will Deacon <[email protected]>
diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
index 536d572e5596..9d1b06d67c53 100644
--- a/arch/arm64/kernel/cpufeature.c
+++ b/arch/arm64/kernel/cpufeature.c
@@ -868,6 +868,7 @@ static bool unmap_kernel_at_el0(const struct
arm64_cpu_capabilities *entry,
static const struct midr_range kpti_safe_list[] = {
MIDR_ALL_VERSIONS(MIDR_CAVIUM_THUNDERX2),
MIDR_ALL_VERSIONS(MIDR_BRCM_VULCAN),
+ { /* sentinel */ }
};
char const *str = "command line option";
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1857074
Title:
Cavium ThunderX CN88XX Panic : Unknown reason
Status in linux package in Ubuntu:
Confirmed
Status in linux source package in Bionic:
Confirmed
Bug description:
Series: Bionic
Kernel: 4.15.0-74.84 linux-generic
Steps to reproduce: Install 4.15.0-74.84 Kernel and boot the system.
The following crash was observed while testing the proposed kernel for the
2019.12.02 SRU Cycle.
This kernel was built to include fixes for the following bugs:
* [Regression] Bionic kernel 4.15.0-71.80 can not boot on ThunderX
(LP: #1853326)
- Revert "arm64: Use firmware to detect CPUs that are not affected by
Spectre-v2"
- Revert "arm64: Get rid of __smccc_workaround_1_hvc_*"
* [Regression] Bionic kernel 4.15.0-71.80 can not boot on ThunderX2 and
Kunpeng920 (LP: #1852723)
- SAUCE: arm64: capabilities: Move setup_boot_cpu_capabilities() call to
correct place
The following crash appears to be a NEW bug. not related to the prior bugs
listed above.
This bug DOES NOT APPEAR to be related to LP#1857073.
This is another NEW BUG.
Hostname: Starmie
Probable Cause is unknown at this point and still under investigation.
[ OK ] Found device WDC_WD5003ABYZ-011FA0 efi.
Mounting /boot/efi...
[ OK ] Mounted /boot/efi.
[ OK ] Reached target Local File Systems.
Starting AppArmor initialization...
Starting Tell Plymouth To Write Out Runtime Data...
Starting ebtables ruleset management...
[ 20.942427] kernel BUG at
/build/linux-pWET3k/linux-4.15.0/fs/buffer.c:1240!
[ 20.951416] Internal error: Oops - BUG: 0 [#1] SMP
[ 20.958153] Modules linked in: nls_iso8859_1 thunderx_edac thunderx_zip
cavium_rng_vf shpchp cavium_rng gpio_keys uio_pdrv_genirq ipmi_ssif uio
ipmi_devintf ipmi_msghandler sch_fq_codel ib_iser rdma_cm iw_cm ib_cm ib_core
iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi ip_tables x_tables autofs4
btrfs zstd_compress raid10 raid456 async_raid6_recov async_memcpy async_pq
async_xor async_tx xor raid6_pq libcrc32c raid1 raid0 multipath linear nicvf
nicpf ast i2c_algo_bit ttm drm_kms_helper syscopyarea sysfillrect aes_ce_blk
sysimgblt fb_sys_fops aes_ce_cipher crc32_ce drm crct10dif_ce ghash_ce sha2_ce
sha256_arm64 sha1_ce ahci thunder_bgx libahci thunder_xcv i2c_thunderx
mdio_thunder thunderx_mmc mdio_cavium aes_neon_bs aes_neon_blk crypto_simd
cryptd aes_arm64
[ 21.044326] Process systemd (pid: 1, stack limit = 0x000000005af6f18b)
[ 21.053858] CPU: 1 PID: 1 Comm: systemd Not tainted 4.15.0-74-generic
#84-Ubuntu
[ 21.063931] Hardware name: Cavium ThunderX CRB/To be filled by O.E.M.,
BIOS 5.11 12/12/2012
[ 21.074790] pstate: 20400085 (nzCv daIf +PAN -UAO)
[ 21.082096] pc : __find_get_block+0x2e8/0x398
[ 21.088917] lr : __getblk_gfp+0x3c/0x2a8
[ 21.095379] sp : ffff0000099ab7e0
[ 21.101062] x29: ffff0000099ab7e0 x28: 0000000000000000
[ 21.108699] x27: 0000000000000000 x26: 0000000000000000
[ 21.116265] x25: 0000000000000001 x24: 0000000000000000
[ 21.123788] x23: 0000000000000008 x22: ffff801f26116c80
[ 21.131302] x21: ffff801f26116c80 x20: 000000000000245c
[ 21.138808] x19: 0000000000001000 x18: 0000ffffa59c3a70
[ 21.146300] x17: 0000000000000000 x16: 0000000000000000
[ 21.153730] x15: 0000000000000020 x14: 0000000000000012
[ 21.161083] x13: 2f7374696e752f64 x12: 0101010101010101
[ 21.168397] x11: 7f7f7f7f7f7f7f7f x10: ffff00000972d000
[ 21.175689] x9 : 0000000000000000 x8 : ffff801f7ba7e3c0
[ 21.183042] x7 : ffff801f7ba7e3e0 x6 : 0000000000000000
[ 21.190667] x5 : 0000000000000004 x4 : 0000000000000020
[ 21.197955] x3 : 0000000000000008 x2 : 0000000000001000
[ 21.205680] x1 : 000000000000245c x0 : 0000000000000080
[ 21.212918] Call trace:
[ 21.217257] __find_get_block+0x2e8/0x398
[ 21.223160] __getblk_gfp+0x3c/0x2a8
[ 21.228644] ext4_getblk+0xcc/0x1b0
[ 21.233991] ext4_bread_batch+0x78/0x1c8
[ 21.239726] ext4_find_entry+0x2d4/0x598
[ 21.245416] ext4_lookup+0xac/0x278
[ 21.250612] lookup_slow+0xac/0x190
[ 21.255736] walk_component+0x228/0x340
[ 21.261151] link_path_walk+0x2f4/0x568
[ 21.266499] path_parentat+0x44/0x88
[ 21.271521] filename_parentat+0xa0/0x170
[ 21.276924] filename_create+0x60/0x168
[ 21.282082] SyS_symlinkat+0x80/0x128
[ 21.287013] el0_svc_naked+0x30/0x34
[ 21.291835] Code: 17ffffe7 a90363b7 a9046bb9 f9002bbb (d4210000)
[ 21.299191] ---[ end trace b07cecc329f07f48 ]---
[ 21.347488] systemd: 35 output lines suppressed due to ratelimiting
[ 21.355094] Kernel panic - not syncing: Attempted to kill init!
exitcode=0x0000000b
[ 21.355094]
[ 21.366666] SMP: stopping secondary CPUs
[ 21.371817] Kernel Offset: disabled
[ 21.376517] CPU features: 0x00901108
[ 21.381310] Memory Limit: none
[ 21.385617] ---[ end Kernel panic - not syncing: Attempted to kill init!
exitcode=0x0000000b
[ 21.385617]
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1857074/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
