I've verified this LP in all 3 releases, by installing the package sin
-proposed and checking the command-line of kdump kernel, which contains
"reset_devices" for all the 3 versions tested:

1:1.6.3-2~16.04.2 for xenial,
1:1.6.5-1ubuntu1~18.04.4 for bionic,
1:1.6.6-2ubuntu2 for eoan.

Cheers,


Guilherme

** Changed in: makedumpfile (Ubuntu Trusty)
   Importance: High => Undecided

** Changed in: makedumpfile (Ubuntu Trusty)
     Assignee: Guilherme G. Piccoli (gpiccoli) => (unassigned)

** Tags removed: verification-needed verification-needed-bionic 
verification-needed-eoan verification-needed-xenial
** Tags added: verification-done verification-done-bionic 
verification-done-eoan verification-done-xenial

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to makedumpfile in Ubuntu.
https://bugs.launchpad.net/bugs/1800566

Title:
  Make reset_devices parameter default for kdump

Status in makedumpfile package in Ubuntu:
  Fix Released
Status in makedumpfile source package in Trusty:
  Won't Fix
Status in makedumpfile source package in Xenial:
  Fix Committed
Status in makedumpfile source package in Bionic:
  Fix Committed
Status in makedumpfile source package in Cosmic:
  Won't Fix
Status in makedumpfile source package in Disco:
  Won't Fix
Status in makedumpfile source package in Eoan:
  Fix Committed
Status in makedumpfile source package in Focal:
  Fix Released

Bug description:
  [Impact]

  * Kdump does not configure by default the crash kernel to perform a
  device reset by default, by passing the "reset_devices" parameter.

  * Kernel has the "reset_devices" parameter that drivers can opt-in,
  and perform special activity in case this parameter is parsed from
  command-line. For example, in kdump kernels it hints the drivers that
  they are booting from a non-healthy condition and needs to issue some
  form of reset to the adapter, like clearing DMA mapping in their
  firmware for example. Users currently (kernel v5.5-rc2) are: aacraid,
  hpsa, ipr, megaraid_sas, mpt3sas, smartpqi, xenbus.

  This should be enabled by default in the kdump config file to be added
  in the kdump kernel command-line for all versions.

  [Test Case]

  1) Deploy a Bionic VM e.g. with uvt-kvm
  2) Install the kdump-tools package
  3) Run `kdump-config test`and check for the 'reset_devices' parameter:

  $ kdump-config test
  ...
  kexec command to be used:
    /sbin/kexec -p --command-line="BOOT_IMAGE=/boot/vmlinuz-4.15.0-45-generic 
root=LABEL=cloudimg-rootfs ro console=tty1 console=ttyS0 nr_cpus=1 
systemd.unit=kdump-tools.service irqpoll nousb ata_piix.prefer_ms_hyperv=0" 
/var/lib/kdump/vmlinuz

  
  [Regression Potential]

  The regression potential is low, since it doesn't need any changes in
  makedumpfile code and we're only adding a parameter on the crash
  kernel command-line. The risks are related with bad behavior with the
  kernel when using "reset_devices", like if the driver has bugs in this
  path. It's considered safer to have the option (and this way prevent
  problems for booting a unhealthy kernel with potential stuck DMAs in
  the devices) than not having it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to