Hi Jeff,
after testing the feature we see that some devlink functionality is missing in
our driver and we must add them before adding the ROCE feature.
This missing functionality is the implementation of devlink reload and
it was introduced upstream by the following two patches:
4383cfcc65e7 ("net/mlx5: Add devlink reload")
32680da71034 ("net/mlx5: Remove unneeded variable in mlx5_unload_one")
the above patches applied cleanly over your tree but we have some
compiling issue since the following patch are missing:
070c63f20f6c ("net: devlink: allow to change namespaces during reload")
these compiling issues can be resolved by aligned
mlx5_devlink_reload_down to Focal devlink_ops->reload_down by removing
the 'bool netns_change' parameter from mlx5_devlink_reload_down
function.
Thanks,
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1877270
Title:
Devlink - add RoCE disable kernel support
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Focal:
In Progress
Status in linux source package in Groovy:
In Progress
Bug description:
[Impact]
RoCE disable feature was added to the kernel v5.5.
This feature was requested by Mellanox customers that use Ubuntu 20.04,
and it's a very high important to deliver this feature to the customers
in one of ubuntu 20.04 SRU.
[SHORT DESCRIPTION]
RoCE enablement state controls driver support for RoCE traffic.
When RoCE is disabled, there is no gid table, only raw ethernet QPs are
supported and traffic on the well known UDP RoCE port is handled as raw
ethernet traffic.
[Test Case]
To change RoCE enablement state a user must change the driverinit
cmode value and run devlink reload.
User command examples:
- Disable RoCE::
$ devlink dev param set pci/0000:06:00.0 name enable_roce value false
cmode driverinit
$ devlink dev reload pci/0000:06:00.0
- Read RoCE enablement state::
$ devlink dev param show pci/0000:06:00.0 name enable_roce
pci/0000:06:00.0:
name enable_roce type generic
values:
cmode driverinit value true
[Regression Potential]
This feature shouldn't affect the regression because it's only adding support
for
RoCE enable/disable.
Also,
This feature was tested internally by Mellanox QA teams
those tests logs/results are private unfortunately i can't share it here
[Other Info]
Feature patchset:
94de879c28d8 IB/mlx5: Load profile according to RoCE enablement state
b5a498baf929 IB/mlx5: Rename profile and init methods
cc9defcbb8fa net/mlx5: Handle "enable_roce" devlink param
e90cde0d76f0 net/mlx5: Document flow_steering_mode devlink param
6c7295e13ffd devlink: Add new "enable_roce" generic device param
patctwork:
https://patchwork.ozlabs.org/cover/1192314/
userspace:
No userspace dependency on this. the feature uses the devlink
param functionality which already exists in UB20.04.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1877270/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
