https://lists.ubuntu.com/archives/kernel-team/2023-March/137886.html
** Description changed: + [Impact] + On s390x LPAR instances, this test will fail with: + # File "linux/tools/testing/selftests/net/devlink_port_split.py", line 64, in get_if_names + # if ports[port]['flavour'] == 'physical': + # KeyError: 'flavour' + not ok 1 selftests: net: devlink_port_split.py # exit=1 + This is because the mlx4 driver in use on this instance does not set + attributes, therefore `devlink -j port show` command output does not + contain this "flavour" key. + + [Fix] + * 3de66d08d3 selftests: net: devlink_port_split.py: skip test if no + suitable device available + + This patch can be cherry-picked into our J/K/L kernels. + + [Test] + Run the patched devlink_port_split.py on s390x LPAR, and it won't + fail with # KeyError: 'flavour' but marked as SKIP instead. + + [Where problems could occur] + If this change is incorrect, it may affect the test result, however it's + limited to testing tools, no actual impact to kernel functions. + + + [Original Bug Report] Failing on hirsute/linux 5.11.0-26.28 host s2lp4 Not a regression as this is also failing on 5.11.0-24.25 - 17:16:32 DEBUG| [stdout] # selftests: net: devlink_port_split.py 17:16:32 DEBUG| [stdout] # Traceback (most recent call last): 17:16:32 DEBUG| [stdout] # File "/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net/./devlink_port_split.py", line 283, in <module> 17:16:32 DEBUG| [stdout] # main() 17:16:32 DEBUG| [stdout] # File "/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net/./devlink_port_split.py", line 256, in main 17:16:32 DEBUG| [stdout] # ports = devlink_ports(dev) 17:16:32 DEBUG| [stdout] # File "/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net/./devlink_port_split.py", line 70, in __init__ 17:16:32 DEBUG| [stdout] # self.if_names = devlink_ports.get_if_names(dev) 17:16:32 DEBUG| [stdout] # File "/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net/./devlink_port_split.py", line 64, in get_if_names 17:16:32 DEBUG| [stdout] # if ports[port]['flavour'] == 'physical': 17:16:32 DEBUG| [stdout] # KeyError: 'flavour' 17:16:32 DEBUG| [stdout] not ok 44 selftests: net: devlink_port_split.py # exit=1 -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1937133 Title: devlink_port_split from ubuntu_kernel_selftests.net fails on hirsute (KeyError: 'flavour') Status in ubuntu-kernel-tests: In Progress Status in linux package in Ubuntu: In Progress Status in linux source package in Hirsute: Won't Fix Status in linux source package in Jammy: In Progress Status in linux source package in Kinetic: In Progress Status in linux source package in Lunar: In Progress Bug description: [Impact] On s390x LPAR instances, this test will fail with: # File "linux/tools/testing/selftests/net/devlink_port_split.py", line 64, in get_if_names # if ports[port]['flavour'] == 'physical': # KeyError: 'flavour' not ok 1 selftests: net: devlink_port_split.py # exit=1 This is because the mlx4 driver in use on this instance does not set attributes, therefore `devlink -j port show` command output does not contain this "flavour" key. [Fix] * 3de66d08d3 selftests: net: devlink_port_split.py: skip test if no suitable device available This patch can be cherry-picked into our J/K/L kernels. [Test] Run the patched devlink_port_split.py on s390x LPAR, and it won't fail with # KeyError: 'flavour' but marked as SKIP instead. [Where problems could occur] If this change is incorrect, it may affect the test result, however it's limited to testing tools, no actual impact to kernel functions. [Original Bug Report] Failing on hirsute/linux 5.11.0-26.28 host s2lp4 Not a regression as this is also failing on 5.11.0-24.25 17:16:32 DEBUG| [stdout] # selftests: net: devlink_port_split.py 17:16:32 DEBUG| [stdout] # Traceback (most recent call last): 17:16:32 DEBUG| [stdout] # File "/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net/./devlink_port_split.py", line 283, in <module> 17:16:32 DEBUG| [stdout] # main() 17:16:32 DEBUG| [stdout] # File "/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net/./devlink_port_split.py", line 256, in main 17:16:32 DEBUG| [stdout] # ports = devlink_ports(dev) 17:16:32 DEBUG| [stdout] # File "/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net/./devlink_port_split.py", line 70, in __init__ 17:16:32 DEBUG| [stdout] # self.if_names = devlink_ports.get_if_names(dev) 17:16:32 DEBUG| [stdout] # File "/home/ubuntu/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/net/./devlink_port_split.py", line 64, in get_if_names 17:16:32 DEBUG| [stdout] # if ports[port]['flavour'] == 'physical': 17:16:32 DEBUG| [stdout] # KeyError: 'flavour' 17:16:32 DEBUG| [stdout] not ok 44 selftests: net: devlink_port_split.py # exit=1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1937133/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp