Ok, "here's a patch from an unmerged branch abandoned a year ago" isn't particularly reassuring. However, investigation reveals that an equivalent commit was merged to trunk and exists in 2.5.1: https://github.com/intel/thermal_daemon/commit/4339234275b87b3973487cade283addd14fc9818
So, reverse-engineering the problem this is fixing: * there exists a laptop with a firmware thermal table that contains a "motion" condition in each of its entries * To determine the policy to apply thermald checks against each condition in each of the table entries. If it encounters a condition it does not understand, the check returns THD_ERROR (and presumably the check fails?) * Since each entry of the firmware table on this laptop contains a "motion" condition, they are all rejected, and thermald instead applies the default "max power" policy. * The patch implements a stub motion condition check - if the table specifies "motion = 0" then the condition is satisfied. Am I correct in that understanding? So the risk of regression here is mostly that thermald will *start working* on such laptops. Or, alternatively, if there is a laptop where *some, but not all* table entries contain a "motion" condition then this will be enabling extra policy options, which might be inappropriate? -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to thermald in Ubuntu. https://bugs.launchpad.net/bugs/2018275 Title: Fix the in-motion function does not work Status in thermald package in Ubuntu: New Status in thermald source package in Jammy: In Progress Bug description: [Summary] in-Motion condition doesn't work with adaptive performance policy [Fix] This patch fix the issue, cc0890a59725) Always match motion = 0 [Test cases] 1. Install the Ubuntu 22.04-oem image on BMM4-DVT2-C2X 2. run the thermald applied the fix. #thermald --no-daemon --loglevel=debug --adaptive --ignore-cpuid-check > thermald_log.log" and check the log 3. in-motion condition works [Where problems could occur] because motion is always 0, the rules with motion=1 wouldn't be hit. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/thermald/+bug/2018275/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
