Public bug reported:

[Impact]

/var/lib/dkms/nvidia/535.129.03/build/nvidia/libspdm_shash.c:90:26: error: 
implicit declaration of function ‘crypto_tfm_ctx_aligned’; did you mean 
‘crypto_tfm_ctx_align’? [-Werror=implicit-function-declaration]
   90 |         char *src_ipad = crypto_tfm_ctx_aligned(&src_tfm->base);
      |                          ^~~~~~~~~~~~~~~~~~~~~~
      |                          crypto_tfm_ctx_align
/var/lib/dkms/nvidia/535.129.03/build/nvidia/libspdm_shash.c:90:26: warning: 
initialization of ‘char *’ from ‘int’ makes pointer from integer without a cast 
[-Wint-conversion]
/var/lib/dkms/nvidia/535.129.03/build/nvidia/libspdm_shash.c:91:26: warning: 
initialization of ‘char *’ from ‘int’ makes pointer from integer without a cast 
[-Wint-conversion]
   91 |         char *dst_ipad = crypto_tfm_ctx_aligned(&dst_tfm->base);
      |                          ^~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

[Test case]

 $ sudo apt install nvidia-dkms-535-server-open

[Fix]

Upstream commit acd7799574e5 ("crypto: shash - remove
crypto_shash_ctx_aligned()") removed crypto_tfm_ctx_aligned() that is
used by the open variant of the driver.

Re-introduce this function (as a static inline) directly in the driver
(like the original one):

static inline void *crypto_tfm_ctx_aligned(struct crypto_tfm *tfm)
{
       return crypto_tfm_ctx_align(tfm, crypto_tfm_alg_alignmask(tfm) + 1);
}

This should fix the build error, since crypto_tfm_ctx_align() is still
available in the kernel ABI.

[Regression potential]

We may experience graphics regressions in systems that are using the
open variant of the 535-server nvidia driver, especially with any 6.7
kernel.

ProblemType: Bug
DistroRelease: Ubuntu 24.04
Package: nvidia-dkms-535-server-open 535.129.03-0ubuntu1
ProcVersionSignature: User Name 6.7.0-5.5-generic 6.7.0-rc8
Uname: Linux 6.7.0-5-generic x86_64
ApportVersion: 2.27.0-0ubuntu6
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudBuildName: server
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSerial: 20240101
CloudSubPlatform: config-disk (/dev/vdb)
Date: Tue Jan  9 08:54:19 2024
ProcEnviron:
 LANG=C.UTF-8
 PATH=(custom, no user)
 SHELL=/bin/bash
 TERM=xterm-256color
 XDG_RUNTIME_DIR=<set>
SourcePackage: nvidia-graphics-drivers-535-server
UpgradeStatus: No upgrade log present (probably fresh install)

** Affects: nvidia-graphics-drivers-535-server (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: nvidia-graphics-drivers-535-server (Ubuntu Noble)
     Importance: Undecided
         Status: New


** Tags: amd64 apport-bug cloud-image noble

** Also affects: nvidia-graphics-drivers-535-server (Ubuntu Noble)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to nvidia-graphics-drivers-535-server in
Ubuntu.
https://bugs.launchpad.net/bugs/2048758

Title:
  nvidia-dkms-535-server-open FTBS with the latest 6.7 kernel in noble

Status in nvidia-graphics-drivers-535-server package in Ubuntu:
  New
Status in nvidia-graphics-drivers-535-server source package in Noble:
  New

Bug description:
  [Impact]

  /var/lib/dkms/nvidia/535.129.03/build/nvidia/libspdm_shash.c:90:26: error: 
implicit declaration of function ‘crypto_tfm_ctx_aligned’; did you mean 
‘crypto_tfm_ctx_align’? [-Werror=implicit-function-declaration]
     90 |         char *src_ipad = crypto_tfm_ctx_aligned(&src_tfm->base);
        |                          ^~~~~~~~~~~~~~~~~~~~~~
        |                          crypto_tfm_ctx_align
  /var/lib/dkms/nvidia/535.129.03/build/nvidia/libspdm_shash.c:90:26: warning: 
initialization of ‘char *’ from ‘int’ makes pointer from integer without a cast 
[-Wint-conversion]
  /var/lib/dkms/nvidia/535.129.03/build/nvidia/libspdm_shash.c:91:26: warning: 
initialization of ‘char *’ from ‘int’ makes pointer from integer without a cast 
[-Wint-conversion]
     91 |         char *dst_ipad = crypto_tfm_ctx_aligned(&dst_tfm->base);
        |                          ^~~~~~~~~~~~~~~~~~~~~~
  cc1: some warnings being treated as errors

  [Test case]

   $ sudo apt install nvidia-dkms-535-server-open

  [Fix]

  Upstream commit acd7799574e5 ("crypto: shash - remove
  crypto_shash_ctx_aligned()") removed crypto_tfm_ctx_aligned() that is
  used by the open variant of the driver.

  Re-introduce this function (as a static inline) directly in the driver
  (like the original one):

  static inline void *crypto_tfm_ctx_aligned(struct crypto_tfm *tfm)
  {
         return crypto_tfm_ctx_align(tfm, crypto_tfm_alg_alignmask(tfm) + 1);
  }

  This should fix the build error, since crypto_tfm_ctx_align() is still
  available in the kernel ABI.

  [Regression potential]

  We may experience graphics regressions in systems that are using the
  open variant of the 535-server nvidia driver, especially with any 6.7
  kernel.

  ProblemType: Bug
  DistroRelease: Ubuntu 24.04
  Package: nvidia-dkms-535-server-open 535.129.03-0ubuntu1
  ProcVersionSignature: User Name 6.7.0-5.5-generic 6.7.0-rc8
  Uname: Linux 6.7.0-5-generic x86_64
  ApportVersion: 2.27.0-0ubuntu6
  Architecture: amd64
  CasperMD5CheckResult: unknown
  CloudArchitecture: x86_64
  CloudBuildName: server
  CloudID: nocloud
  CloudName: unknown
  CloudPlatform: nocloud
  CloudSerial: 20240101
  CloudSubPlatform: config-disk (/dev/vdb)
  Date: Tue Jan  9 08:54:19 2024
  ProcEnviron:
   LANG=C.UTF-8
   PATH=(custom, no user)
   SHELL=/bin/bash
   TERM=xterm-256color
   XDG_RUNTIME_DIR=<set>
  SourcePackage: nvidia-graphics-drivers-535-server
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nvidia-graphics-drivers-535-server/+bug/2048758/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to