Reviewed zfs-linux on mantic/jammy/focal-unapproved for acceptance.
They all look good to me (notes below, in addition to usual checks),
but I'll ask for another reviewer to provide input too, as it's ZFS.
(But I did want to provide some assistance in this long-running SRU.)
Thanks,
Mauricio
...
mantic:
The code change looks good and hasn't changed further upstream.
(There are suggested /alternatives/ in Draft state [1], but the draft
reassures that the original, merged PR is correct.)
The [Test Plan] section provides both a specific reproducer and
general testing (in many forms), which is reassuring for -proposed
verification.
P.S.: not very polished changelog/patch files, but combined they do
provide the information to find the LP bug and upstream/commit, usually found
via DEP-3 headers as Origin/Bug-Ubuntu.
(Style isn't the most important thing in this case or at the moment.)
$ git log --oneline zfs-2.2.2 -- module/zfs/dnode.c | grep -m1
'dnode_is_dirty: check dnode and its data for dirtiness'
9b9b09f452a4 dnode_is_dirty: check dnode and its data for dirtiness
jammy:
Likewise.
Regarding the point release, 22.04.4 (scheduled for Feb 22 [2]),
we are still before 'Release minus 14 (or 7) days' [3]
(when '6. Coordinate with the SRU team' and '7. ... -updates pocket
freeze' happen).
$ git log --oneline zfs-2.1.14 -- module/zfs/dnode.c | grep -m1
'dnode_is_dirty: check dnode and its data for dirtiness'
77b0c6f0403b dnode_is_dirty: check dnode and its data for dirtiness
focal:
The code change is a backport not from upstream (0.8 no longer
maintained, apparently),
but comes from the original author of the patch (and noted with DEP-3
Origin:, great!),
and looks equivalent (same code change, just in a different function
and context).
[4]
links:
[1] https://github.com/openzfs/zfs/pull/15615
[2] https://discourse.ubuntu.com/t/jammy-jellyfish-release-schedule/23906
[3] https://wiki.ubuntu.com/PointReleaseProcess
[4] https://github.com/robn/zfs/commit/f2f7f43a9bf4628328292f25b1663b873f271b1a
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2044657
Title:
Multiple data corruption issues in zfs
Status in zfs-linux package in Ubuntu:
Fix Released
Status in zfs-linux source package in Xenial:
Confirmed
Status in zfs-linux source package in Bionic:
Confirmed
Status in zfs-linux source package in Focal:
In Progress
Status in zfs-linux source package in Jammy:
In Progress
Status in zfs-linux source package in Lunar:
Won't Fix
Status in zfs-linux source package in Mantic:
In Progress
Status in zfs-linux source package in Noble:
Fix Released
Bug description:
[ Impact ]
* Multiple data corruption issues have been identified and fixed in
ZFS. Some of them, at varying real-life reproducibility frequency have
been deterimed to affect very old zfs releases. Recommendation is to
upgrade to 2.2.2 or 2.1.14 or backport dnat patch alone. This is to
ensure users get other potentially related fixes and runtime tunables
to possibly mitigate other bugs that are related and are being fixed
upstream for future releases.
* For jammy the 2.1.14 upgrade will bring HWE kernel support and also
compatiblity/support for hardened kernel builds that mitigate SLS
(straight-line-speculation).
* In the absence of the upgrade a cherry-pick will address this
particular popular issue alone - without addressing other issues
w.r.t. Redbleed / SLS, bugfixes around trim support, and other related
improvements that were discovered and fixed around the same time as
this popular issue.
[ Test Plan ]
* !!! Danger !!! use reproducer from
https://zfsonlinux.topicbox.com/groups/zfs-discuss/T12876116b8607cdb
and confirm if that issue is resolved or not. Do not run on production
ZFS pools / systems.
* autopkgtest pass (from https://ubuntu-archive-
team.ubuntu.com/proposed-migration/ )
* adt-matrix pass (from https://kernel.ubuntu.com/adt-matrix/ )
* kernel regression zfs testsuite pass (from Kernel team RT test
results summary, private)
* zsys integration test pass (upgrade of zsys installed systems for
all releases)
* zsys install test pass (for daily images of LTS releases only that
have such installer support, as per iso tracker test case)
* LXD (ping LXD team to upgrade vendored in tooling to 2.2.2 and
2.1.14, and test LXD on these updated kernels)
[ Where problems could occur ]
* Upgrade to 2.1.14 on jammy with SLS mitigations compatiblity will
introduce slight slow down on amd64 (for hw accelerated assembly code-
paths only in the encryption primitives)
* Uncertain of the perfomance impact of the extra checks in dnat
patch fix itself. Possibly affecting speed of operation, at the
benefit of correctness.
* The cherry-picked patch ("dnat"? dnode) changes the dirty data check, but
only makes it stronger and not weaker, thus if it were incorrect, likely
only performance would be impacted (and it is unlikely to be incorrect
given upstream reviews and attention to data corruption issues; also,
there are no additional changes to that function upstream)
[ Other Info ]
* https://github.com/openzfs/zfs/pull/15571 is most current
consideration of affairs
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2044657/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
