Included the same commit from upstream updates.
commit 233a95fd574fde1c375c486540a90304a2d2d49f (tag: soundwire-6.11-fixes_2)
Author: Krzysztof Kozlowski <[email protected]>
Date: Mon Sep 9 18:47:46 2024 +0200
soundwire: stream: Revert "soundwire: stream: fix programming slave ports
for non-continous port maps"
This reverts commit ab8d66d132bc8f1992d3eb6cab8d32dda6733c84 because it
breaks codecs using non-continuous masks in source and sink ports. The
commit missed the point that port numbers are not used as indices for
iterating over prop.sink_ports or prop.source_ports.
Soundwire core and existing codecs expect that the array passed as
prop.sink_ports and prop.source_ports is continuous. The port mask still
might be non-continuous, but that's unrelated.
Reported-by: Bard Liao <[email protected]>
Closes:
https://lore.kernel.org/all/[email protected]/
Fixes: ab8d66d132bc ("soundwire: stream: fix programming slave ports for
non-continous port maps")
Acked-by: Bard Liao <[email protected]>
Reviewed-by: Charles Keepax <[email protected]>
Cc: [email protected]
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Tested-by: Peter Ujfalusi <[email protected]>
Link:
https://lore.kernel.org/r/[email protected]
Signed-off-by: Vinod Koul <[email protected]>
** Changed in: linux-oem-6.11 (Ubuntu Noble)
Status: In Progress => Fix Released
** Changed in: linux-oem-6.11 (Ubuntu)
Status: New => Invalid
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux-oem-6.11 in Ubuntu.
https://bugs.launchpad.net/bugs/2078783
Title:
revert the commit which breaks the soundwire audio in v6.11-rc6
Status in linux-oem-6.11 package in Ubuntu:
Invalid
Status in linux-oem-6.11 source package in Noble:
Fix Released
Bug description:
[Impact]
The commit included in v6.11-rc6 has been reported that breaks the audio.
ab8d66d132bc soundwire: stream: fix programming slave ports for non-continous
port maps
https://lore.kernel.org/alsa-
devel/[email protected]/T/#m08e3dd833c64a99d5707de3440b3857c521ed242
[Fix]
The patch author submitted patch to revert it.
https://lore.kernel.org/alsa-devel/[email protected]/T/#u
[Test]
The issue could be reproduce on Dell Bolan, so just check if the audio works
on the machine.
[Where problems could occur]
It won't change anything and the issue addressed by the ab8d66d132bc
("soundwire: stream: fix programming slave ports for non-continous port maps")
didn't fix actually.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-oem-6.11/+bug/2078783/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
