We run make listnewconfig even if listnewconfig_fail is not set. Eg, if we
build using "--with vanilla". But in that case we simply ignore the results of
that make target.

If we don't care about the results we might as well not run this make target.
So only run it if listnewconfig_fail is set.

Signed-off-by: Paul Bolle <[email protected]>
---
 kernel.spec | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel.spec b/kernel.spec
index 08bfd7a9eac1..f0fe21fef94b 100644
--- a/kernel.spec
+++ b/kernel.spec
@@ -1250,14 +1250,14 @@ for i in *.config
 do
   mv $i .config
   Arch=`head -1 .config | cut -b 3-`
-  make ARCH=$Arch listnewconfig | grep -E '^CONFIG_' >.newoptions || true
 %if %{listnewconfig_fail}
+  make ARCH=$Arch listnewconfig | grep -E '^CONFIG_' >.newoptions || true
   if [ -s .newoptions ]; then
     cat .newoptions
     exit 1
   fi
-%endif
   rm -f .newoptions
+%endif
   make -s ARCH=$Arch oldnoconfig
   echo "# $Arch" > configs/$i
   cat .config >> configs/$i
-- 
2.7.4
_______________________________________________
kernel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to