On 7/31/20 11:15 AM, Jiri Benc wrote:
> On Fri, 31 Jul 2020 14:55:54 -0000, GitLab Bridge on behalf of prarit wrote:
>> +fedora-configs: dist-configs-prep
>> +    @cd $(REDHAT)/configs; rm -f *rhel*.config
>> +
>> +rh-configs: dist-configs-prep
>> +    @cd $(REDHAT)/configs; rm -f *fedora*.config
> 
> Prarit, I wouldn't expect doing
> 
> make fedora-configs
> make rh-configs
> 
> in succession resulting in only rhel configs being present.

Oh good point.

> 
> Could we do better? Enhancing build_configs.sh to support flavors being
> specified on command line and falling back to the 'flavors' file only
> when there are none specified seems to me to be a better approach. It
> would also speed up the config generation.

This is definitely a better approach.  I'll go that route.

P.

> 
> Thanks,
> 
>  Jiri
> 
_______________________________________________
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org

Reply via email to