On 9/30/20 9:38 AM, GitLab Bridge on behalf of jeremycline wrote:
> From: Fedora Kernel Team <kernel-t...@fedoraproject.org>
> 
> Hi,
> 
> As part of the ongoing rebase effort, the following configuration
> options need to be reviewed.
> 
> As a reminder, the ARK configuration flow involves moving unreviewed
> configuration options from the pending directory to the ark directory.
> In the diff below, options are removed from the pending directory and
> added to the ark hierarchy. The final options that need to be ACKed
> are the files that are being added to the ark hierarchy.
> 
> If the value for a file that is added should be changed, please reply
> with a better option.
> 
>  CONFIG_DEBUG_VM_PGTABLE:
> 
>  This option provides a debug method which can be used to test
>  architecture page table helper functions on various platforms in
>  verifying if they comply with expected generic MM semantics. This
>  will help architecture code in making sure that any changes or
>  new additions of these helpers still conform to expected
>  semantics of the generic MM. Platforms will have to opt in for
>  this through ARCH_HAS_DEBUG_VM_PGTABLE.
> 
>  If unsure, say N.
> 
>  Symbol: DEBUG_VM_PGTABLE [=n]
>  Type  : bool
>  Defined at lib/Kconfig.debug:702
>    Prompt: Debug arch page table for semantics compliance
>    Depends on: MMU [=y] && ARCH_HAS_DEBUG_VM_PGTABLE [=y]
>    Location:
>      -> Kernel hacking
>        -> Memory Debugging
> 

Nacked-by: Prarit Bhargava <pra...@redhat.com>

Let's enable this for the debug kernels but not for the main kernel.

P.
> Cc: Prarit Bhargava <pra...@redhat.com>
> ---
>  .../common/generic/CONFIG_DEBUG_VM_PGTABLE    |  1 +
>  .../configs/common/generic/CONFIG_TEST_BITOPS |  1 +
>  .../generic/CONFIG_DEBUG_VM_PGTABLE           | 24 -------------------
>  .../pending-common/generic/CONFIG_TEST_BITOPS | 24 -------------------
>  4 files changed, 2 insertions(+), 48 deletions(-)
>  create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_VM_PGTABLE
>  create mode 100644 redhat/configs/common/generic/CONFIG_TEST_BITOPS
>  delete mode 100644 
> redhat/configs/pending-common/generic/CONFIG_DEBUG_VM_PGTABLE
>  delete mode 100644 redhat/configs/pending-common/generic/CONFIG_TEST_BITOPS
> 
> diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_VM_PGTABLE 
> b/redhat/configs/common/generic/CONFIG_DEBUG_VM_PGTABLE
> new file mode 100644
> index 000000000000..2dabf3429c81
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_DEBUG_VM_PGTABLE
> @@ -0,0 +1 @@
> +# CONFIG_DEBUG_VM_PGTABLE is not set
> diff --git a/redhat/configs/common/generic/CONFIG_TEST_BITOPS 
> b/redhat/configs/common/generic/CONFIG_TEST_BITOPS
> new file mode 100644
> index 000000000000..245f24428550
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_TEST_BITOPS
> @@ -0,0 +1 @@
> +# CONFIG_TEST_BITOPS is not set
> diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_VM_PGTABLE 
> b/redhat/configs/pending-common/generic/CONFIG_DEBUG_VM_PGTABLE
> deleted file mode 100644
> index 9f311469e240..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_VM_PGTABLE
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -# CONFIG_DEBUG_VM_PGTABLE:
> -# 
> -# This option provides a debug method which can be used to test
> -# architecture page table helper functions on various platforms in
> -# verifying if they comply with expected generic MM semantics. This
> -# will help architecture code in making sure that any changes or
> -# new additions of these helpers still conform to expected
> -# semantics of the generic MM. Platforms will have to opt in for
> -# this through ARCH_HAS_DEBUG_VM_PGTABLE.
> -# 
> -# If unsure, say N.
> -# 
> -# Symbol: DEBUG_VM_PGTABLE [=n]
> -# Type  : bool
> -# Defined at lib/Kconfig.debug:702
> -#   Prompt: Debug arch page table for semantics compliance
> -#   Depends on: MMU [=y] && ARCH_HAS_DEBUG_VM_PGTABLE [=y]
> -#   Location:
> -#     -> Kernel hacking
> -#       -> Memory Debugging
> -# 
> -# 
> -# 
> -# CONFIG_DEBUG_VM_PGTABLE is not set
> diff --git a/redhat/configs/pending-common/generic/CONFIG_TEST_BITOPS 
> b/redhat/configs/pending-common/generic/CONFIG_TEST_BITOPS
> deleted file mode 100644
> index 86e8dea053dc..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_TEST_BITOPS
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -# CONFIG_TEST_BITOPS:
> -# 
> -# This builds the "test_bitops" module that is much like the
> -# TEST_LKM module except that it does a basic exercise of the
> -# clear_bit and set_bit macros to make sure there are no compiler
> -# warnings from C=1 sparse checker or -Wextra compilations. It has
> -# no dependencies and doesn't run or load unless explicitly requested
> -# by name.  for example: modprobe test_bitops.
> -# 
> -# If unsure, say N.
> -# 
> -# Symbol: TEST_BITOPS [=n]
> -# Type  : tristate
> -# Defined at lib/Kconfig.debug:2025
> -#   Prompt: Test module for compilation of clear_bit/set_bit operations
> -#   Depends on: RUNTIME_TESTING_MENU [=y] && m && MODULES [=y]
> -#   Location:
> -#     -> Kernel hacking
> -#       -> Kernel Testing and Coverage
> -#         -> Runtime Testing (RUNTIME_TESTING_MENU [=y])
> -# 
> -# 
> -# 
> -# CONFIG_TEST_BITOPS is not set
> 
_______________________________________________
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org

Reply via email to