From: Herton R. Krzesinski on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1721#note_895049612
So this papers over the real problem. I looked at the Makefile and wonder why
CFLAGS wasn't being passed over even with "override" being used to append the
flags. Seems the real problem is that the updated CFLAGS aren't being passed
to the submake used to build the tool. I did this here and it seems to have
fixed the problem:
```
$ git diff
diff --git a/tools/power/x86/intel-speed-select/Makefile
b/tools/power/x86/intel-speed-select/Makefile
index d2fba1297d96..0858aba12d21 100644
--- a/tools/power/x86/intel-speed-select/Makefile
+++ b/tools/power/x86/intel-speed-select/Makefile
@@ -40,7 +40,7 @@ prepare: $(OUTPUT)include/linux/isst_if.h
$(OUTPUT)include/linux/thermal.h
ISST_IN := $(OUTPUT)intel-speed-select-in.o
$(ISST_IN): prepare FORCE
- $(Q)$(MAKE) $(build)=intel-speed-select
+ $(Q)$(MAKE) CFLAGS="$(CFLAGS)" $(build)=intel-speed-select
$(OUTPUT)intel-speed-select: $(ISST_IN)
$(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@
```
I'm not a make expert, so there may be a better solution. But with above, at
least the proper CFLAGS are being given now (the additional ones given in the
override line). This also is more future proof in case more flags/include
directives are given through CFLAGS.
_______________________________________________
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
