From: Patrick Talbert <ptalb...@redhat.com>

redhat: Use a context manager in merge.py for opening the config file for 
reading

Signed-off-by: Clark Williams <willi...@redhat.com>

diff --git a/redhat/configs/merge.py b/redhat/configs/merge.py
index blahblah..blahblah 100644
--- a/redhat/configs/merge.py
+++ b/redhat/configs/merge.py
@@ -25,14 +25,15 @@ def usage(msg):
 # read a config file and return a dictionary of the contents
 def read_config_file(cfgfile):
     configs = {}
-    for l in [ n.strip() for n in open(cfgfile).readlines()]:
-        if len(l) == 0:  continue
-        if l.startswith("# CONFIG_"):
-            configs[l.split()[1]] = l
-            continue
-        if l.startswith("CONFIG_"):
-            configs[l.split('=')[0]] = l
-            continue
+    with open(cfgfile) as f:
+        for l in [n.strip() for n in f.readlines()]:
+            if not l:  continue
+            if l.startswith("# CONFIG_"):
+                configs[l.split()[1]] = l
+                continue
+            if l.startswith("CONFIG_"):
+                configs[l.split('=')[0]] = l
+                continue
     return configs
 
 

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2117
_______________________________________________
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to