From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2275#note_1355646194
I have no general objections to these changes, however, the commit messages do need to be improved. You have one commit message that is completely empty. We sometimes have to go back and try to figure out why we made a change and having zero information in these commits is going to cause a lot of confusion. Please clean these up. IMO you would have a problem with acceptance in almost any maintained project similar to the size of kernel-ark. _______________________________________________ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue