From: Philipp Rudo on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1821173690
+ arch = path[-1]
+ uki = path[-2]
+ distro = path[-3]
+ for addon_f in filenames:
+ if addon_f.endswith('.addon'):
+ addon_name = addon_f.replace(".addon","")
+ addon_full_name =
f'{addon_name}-{uki}.{distro}.{arch}.addon.efi
I'm not sure if this directory structure is too simple. Thing is that for the
crashkernel= parameter the value is a size. We will need to provide multiple
addons for the parameter for different sizes so users can choose the best
matching one. With the directory structure you are suggesting this means that
we will need to maintain 4 sets of identical addons ((fedora, rhel)*(x86,
aarch64)). Wich will be a constant source of errors.
For configs there is the common/ directory that contains the configs that are
identical for rhel and fedora. In addtions configs contained directly in the
$flavor directory are identical for all arches (unless they explicitely
overwrite it...). Can we do the same for addons as well? That would reduce the
number of redundant definitions and makes managing the addons a lot easier.
--
_______________________________________________
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
