On Wed, Jun 11, 2014 at 1:45 AM, Simon Horman <[email protected]> wrote: > On Tue, Jun 10, 2014 at 09:29:29PM +0200, Yegor Yefremov wrote: >> Breaks build on !largefile toolchains. >> >> Instead simply use whatever mode is selected by toolchain / CFLAGS. > > Perhaps the use of configure or something similar is in order > to select these options if they are available. It seems > to me that one would want them if one can have them.
Do you mean something like this: AC_SYS_LARGEFILE (https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/System-Services.html)? >> Signed-off-by: Peter Korsgaard <[email protected]> >> Signed-off-by: Yegor Yefremov <[email protected]> >> --- >> vmcore-dmesg/vmcore-dmesg.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c >> index f47ee11..9bb1cc2 100644 >> --- a/vmcore-dmesg/vmcore-dmesg.c >> +++ b/vmcore-dmesg/vmcore-dmesg.c >> @@ -1,6 +1,4 @@ >> #define _XOPEN_SOURCE 600 >> -#define _LARGEFILE_SOURCE 1 >> -#define _FILE_OFFSET_BITS 64 >> #include <endian.h> >> #include <byteswap.h> >> #include <stdio.h> >> -- >> 1.8.3.2 >> >> >> _______________________________________________ >> kexec mailing list >> [email protected] >> http://lists.infradead.org/mailman/listinfo/kexec >> _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
