-----Original Message-----
> From: Nisha Parrakat <nisha.parra...@kpit.com>
> 
> Description:
> Static code analysis of makedumpfile code shows a mistake in checking
> the validity of a file descripter just attempted to open.
> 
> arch/ppc64.c: fixed the typo that missed checking fpb that was last attempted 
> to open.
> 
> Found during cppcheck on the code.
> 
> Signed-off-by: Nisha Parrakat <nisha.parra...@kpit.com>
> 
> --- a/arch/ppc64.c    2019-01-29 23:08:27.099027763 +0100
> +++ b/arch/ppc64.c    2019-01-29 23:08:58.567379337 +0100
> @@ -623,7 +623,7 @@
>               return FALSE;
>       }
>       fpb = fopen(f_crashbase, "r");
> -     if (!fp) {
> +     if (!fpb) {
>               ERRMSG("Cannot open %s\n", f_crashbase);
>               fclose(fp);
>               return FALSE;
> 

Thanks, applied to the devel branch.

Kazu




_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Reply via email to